From: Zhou Wang <wangzhou1@hisilicon.com>
To: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: <axboe@fb.com>, <linux-kernel@vger.kernel.org>, <linuxarm@huawei.com>
Subject: Re: [PATCH] lib: scatterlist: Fix to support no mapped sg
Date: Sat, 20 Apr 2019 11:48:12 +0800 [thread overview]
Message-ID: <5CBA967C.5010502@hisilicon.com> (raw)
In-Reply-To: <871s1ymg1k.fsf@belgarion.home>
On 2019/4/19 18:43, Robert Jarzmik wrote:
> Zhou Wang <wangzhou1@hisilicon.com> writes:
>
>> In function sg_split, the second sg_calculate_split will return -EINVAL
>> when in_mapped_nents is 0.
>>
>> Indeed there is no need to do second sg_calculate_split and sg_split_mapped
>> when in_mapped_nents is 0, as in_mapped_nents indicates no mapped entry in
>> original sgl.
>>
>> Signed-off-by: Zhou Wang <wangzhou1@hisilicon.com>
> That's right. May I know what is the usecase which led you to this fix ?
I posted a patchset to support HiSilicon compression engine:
https://lkml.org/lkml/2019/1/23/358. As Herber Xu suggested, it should use
new crypto acomp API which uses sgl as data input and output. However, our
hardware can not handle compress head for input/output data, so I need split
input/output sgl firstly which is not mapped sgl.
New version of HiSilicon compression engine driver has not been posted to
community yet. I will do this later.
>
> Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
Many thanks for your review,
Zhou
>
> --
> Robert
>
> .
>
prev parent reply other threads:[~2019-04-20 3:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-18 9:50 [PATCH] lib: scatterlist: Fix to support no mapped sg Zhou Wang
2019-04-19 10:43 ` Robert Jarzmik
2019-04-20 3:48 ` Zhou Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5CBA967C.5010502@hisilicon.com \
--to=wangzhou1@hisilicon.com \
--cc=axboe@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox