From: xinliang <z.liuxinliang@hisilicon.com>
To: Sam Ravnborg <sam@ravnborg.org>,
John Stultz <john.stultz@linaro.org>, <xuyiping@hisilicon.com>
Cc: Rongrong Zou <zourongrong@gmail.com>,
Xinwei Kong <kong.kongxinwei@hisilicon.com>,
Chen Feng <puck.chen@hisilicon.com>,
lkml <linux-kernel@vger.kernel.org>,
David Airlie <airlied@linux.ie>,
dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [RESEND][PATCH v3 00/26] drm: Kirin driver cleanups to prep for Kirin960 support
Date: Mon, 19 Aug 2019 10:07:24 +0800 [thread overview]
Message-ID: <5D5A045C.5020707@hisilicon.com> (raw)
In-Reply-To: <20190814194508.GA26866@ravnborg.org>
On 2019/8/15 3:45, Sam Ravnborg wrote:
> Hi Xinliang, Rongrong, Xinwei, Chen
>
> On Wed, Aug 14, 2019 at 06:46:36PM +0000, John Stultz wrote:
>> Just wanted to resend this patch set so I didn't have to
>> continue carrying it forever to keep the HiKey960 board running.
>>
>> This patchset contains one fix (in the front, so its easier to
>> eventually backport), and a series of changes from YiPing to
>> refactor the kirin drm driver so that it can be used on both
>> kirin620 based devices (like the original HiKey board) as well
>> as kirin960 based devices (like the HiKey960 board).
>>
>> The full kirin960 drm support is still being refactored, but as
>> this base kirin rework was getting to be substantial, I wanted
>> to send out the first chunk, so that the review burden wasn't
>> overwhelming.
> As Maintainers can we please get some feedback from one of you.
> Just an "OK to commit" would do it.
> But preferably an ack or a review on the individual patches.
Hi sam,
So sorry for responding late.
As I have done a pre-review and talked with the author before sending
out the patches.
So, for this serial patches,
Acked-by: Xinliang Liu <z.liuxinliang@hisilicon.com>
>
> If the reality is that John is the Maintainer today,
> then we should update MAINTAINERS to reflect this.
I am assuming you are talking about the kirin[1] drm driver not the
hibmc[2] one, right?
I really appreciate John's awesome work at kirin drm driver all the way.
Honestly, after my work change from mobile to server years ago, I am
always waiting for some guy who is stably working at kirin drm driver to
take the maintenance work.
John, surely is a such guy. Please add up a patch to update the
maintainer as John, if John agree so. Then John can push the patch set
to drm maintainer himself.
*Note* that the maintainer patch should break hisilicon drivers into
kirin and hibmc two parts, like bellow:
DRM DRIVERS FOR HISILICON HIBMC
M: Xinliang Liu <z.liuxinliang@hisilicon.com>
...
F: drivers/gpu/drm/hisilicon/hibmc
...
DRM DRIVERS FOR HISILICON KIRIN
M: John Stultz <john.stultz@linaro.org>
...
F: drivers/gpu/drm/hisilicon/kirin
...
[1] drivers/gpu/drm/hisilicon/kirin # for kirin mobile display driver
[2] drivers/gpu/drm/hisilicon/hibmc # for server VGA driver
Thanks,
Xinliang
>
> Thanks!
>
> Sam
>
> .
>
next prev parent reply other threads:[~2019-08-19 2:07 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 18:46 [RESEND][PATCH v3 00/26] drm: Kirin driver cleanups to prep for Kirin960 support John Stultz
2019-08-14 18:46 ` [RESEND][PATCH v3 01/26] drm: kirin: Fix for hikey620 display offset problem John Stultz
2019-08-14 18:46 ` [RESEND][PATCH v3 02/26] drm: kirin: Get rid of drmP.h includes John Stultz
2019-08-14 18:46 ` [RESEND][PATCH v3 03/26] drm: kirin: Remove HISI_KIRIN_DW_DSI config option John Stultz
2019-08-14 18:46 ` [RESEND][PATCH v3 04/26] drm: kirin: Remove unreachable return John Stultz
2019-08-14 18:46 ` [RESEND][PATCH v3 05/26] drm: kirin: Remove uncessary parameter indirection John Stultz
2019-08-14 18:46 ` [RESEND][PATCH v3 06/26] drm: kirin: Remove out_format from ade_crtc John Stultz
2019-08-14 18:46 ` [RESEND][PATCH v3 07/26] drm: kirin: Rename ade_plane to kirin_plane John Stultz
2019-08-14 18:46 ` [RESEND][PATCH v3 08/26] drm: kirin: Rename ade_crtc to kirin_crtc John Stultz
2019-08-14 18:46 ` [RESEND][PATCH v3 09/26] drm: kirin: Dynamically allocate the hw_ctx John Stultz
2019-08-14 18:46 ` [RESEND][PATCH v3 10/26] drm: kirin: Move request irq handle in ade hw ctx alloc John Stultz
2019-08-14 18:46 ` [RESEND][PATCH v3 11/26] drm: kirin: Move workqueue to ade_hw_ctx structure John Stultz
2019-08-14 18:46 ` [RESEND][PATCH v3 12/26] drm: kirin: Move kirin_crtc, kirin_plane, kirin_format to kirin_drm_drv.h John Stultz
2019-08-14 18:46 ` [RESEND][PATCH v3 13/26] drm: kirin: Reanme dc_ops to kirin_drm_data John Stultz
2019-08-14 18:46 ` [RESEND][PATCH v3 14/26] drm: kirin: Move ade crtc/plane help functions to driver_data John Stultz
2019-08-14 18:46 ` [RESEND][PATCH v3 15/26] drm: kirin: Move channel formats to driver data John Stultz
2019-08-14 18:46 ` [RESEND][PATCH v3 16/26] drm: kirin: Move mode config function to driver_data John Stultz
2019-08-14 18:46 ` [RESEND][PATCH v3 17/26] drm: kirin: Move plane number and primay plane in driver data John Stultz
2019-08-14 18:46 ` [RESEND][PATCH v3 18/26] drm: kirin: Move config max_width and max_height to " John Stultz
2019-08-14 18:46 ` [RESEND][PATCH v3 19/26] drm: kirin: Move drm driver " John Stultz
2019-08-14 18:46 ` [RESEND][PATCH v3 20/26] drm: kirin: Add register connect helper functions in drm init John Stultz
2019-08-14 18:46 ` [RESEND][PATCH v3 21/26] drm: kirin: Rename plane_init and crtc_init John Stultz
2019-08-14 18:46 ` [RESEND][PATCH v3 22/26] drm: kirin: Fix dev->driver_data setting John Stultz
2019-08-14 18:46 ` [RESEND][PATCH v3 23/26] drm: kirin: Make driver_data variable non-global John Stultz
2019-08-14 18:47 ` [RESEND][PATCH v3 24/26] drm: kirin: Add alloc_hw_ctx/clean_hw_ctx ops in driver data John Stultz
2019-08-14 18:47 ` [RESEND][PATCH v3 25/26] drm: kirin: Pass driver data to crtc init and plane init John Stultz
2019-08-14 18:47 ` [RESEND][PATCH v3 26/26] drm: kirin: Move ade drm init to kirin drm drv John Stultz
2019-08-14 19:45 ` [RESEND][PATCH v3 00/26] drm: Kirin driver cleanups to prep for Kirin960 support Sam Ravnborg
2019-08-19 2:07 ` xinliang [this message]
2019-08-19 4:40 ` Sam Ravnborg
2019-08-19 23:25 ` John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5D5A045C.5020707@hisilicon.com \
--to=z.liuxinliang@hisilicon.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=john.stultz@linaro.org \
--cc=kong.kongxinwei@hisilicon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=puck.chen@hisilicon.com \
--cc=sam@ravnborg.org \
--cc=xuyiping@hisilicon.com \
--cc=zourongrong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox