From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABD7EC3A5A2 for ; Mon, 19 Aug 2019 13:00:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 89B8D2087B for ; Mon, 19 Aug 2019 13:00:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727628AbfHSM77 (ORCPT ); Mon, 19 Aug 2019 08:59:59 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:5156 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727128AbfHSM77 (ORCPT ); Mon, 19 Aug 2019 08:59:59 -0400 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id ACA9CA8B24C2C0ADD55A; Mon, 19 Aug 2019 20:59:55 +0800 (CST) Received: from [127.0.0.1] (10.57.101.250) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.439.0; Mon, 19 Aug 2019 20:59:49 +0800 Subject: Re: [PATCH v2] gpio: pl061: Fix the issue failed to register the ACPI interrtupion To: Andy Shevchenko References: <1565946336-20080-1-git-send-email-xuwei5@hisilicon.com> CC: "open list:GPIO SUBSYSTEM" , "Linux Kernel Mailing List" , linux-arm Mailing List , Linus Walleij , "Rafael J. Wysocki" , "Len Brown" , Mika Westerberg , Linuxarm , , Jonathan Cameron , John Garry , , , , , , , huangdaode From: Wei Xu Message-ID: <5D5A9D43.4040508@hisilicon.com> Date: Mon, 19 Aug 2019 20:59:47 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.57.101.250] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andy, Thanks! On 2019/8/16 21:40, Andy Shevchenko wrote: > On Fri, Aug 16, 2019 at 12:07 PM Wei Xu wrote: >> Invoke acpi_gpiochip_request_interrupts after the acpi data has been >> attached to the pl061 acpi node to register interruption. >> >> Otherwise it will be failed to register interruption for the ACPI case. >> Because in the gpiochip_add_data_with_key, acpi_gpiochip_add is invoked >> after gpiochip_add_irqchip but at that time the acpi data has not been >> attached yet. >> 2. cat /proc/interrupts in the guest console: >> >> estuary:/$ cat /proc/interrupts >> CPU0 >> 2: 3228 GICv3 27 Level arch_timer >> 4: 15 GICv3 33 Level uart-pl011 >> 42: 0 GICv3 23 Level arm-pmu >> IPI0: 0 Rescheduling interrupts >> IPI1: 0 Function call interrupts >> IPI2: 0 CPU stop interrupts >> IPI3: 0 CPU stop (for crash dump) interrupts >> IPI4: 0 Timer broadcast interrupts >> IPI5: 0 IRQ work interrupts >> IPI6: 0 CPU wake-up interrupts >> Err: 0 >> >> But on QEMU v3.0.0 and Linux kernel v5.2.0-rc7, pl061 interruption is >> there as below: >> >> estuary:/$ cat /proc/interrupts >> CPU0 >> 2: 2648 GICv3 27 Level arch_timer >> 4: 12 GICv3 33 Level uart-pl011 >> 42: 0 GICv3 23 Level arm-pmu >> 43: 0 ARMH0061:00 3 Edge ACPI:Event >> IPI0: 0 Rescheduling interrupts >> IPI1: 0 Function call interrupts >> IPI2: 0 CPU stop interrupts >> IPI3: 0 CPU stop (for crash dump) interrupts >> IPI4: 0 Timer broadcast interrupts >> IPI5: 0 IRQ work interrupts >> IPI6: 0 CPU wake-up interrupts >> Err: 0 > In above show only affected line. OK. Will update it in v3. >> And the whole dmesg log on Linux kernel v5.2.0-rc7 is as below: > NO! > Please, remove this huge noise! Sorry for the noise! I will drop it in v3. Best Regards, Wei