From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71F37C3A589 for ; Tue, 20 Aug 2019 09:28:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 50FFE22CF5 for ; Tue, 20 Aug 2019 09:28:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729603AbfHTJ2A (ORCPT ); Tue, 20 Aug 2019 05:28:00 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:54048 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729198AbfHTJ17 (ORCPT ); Tue, 20 Aug 2019 05:27:59 -0400 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 2D54676D1AECF0BE440E; Tue, 20 Aug 2019 17:27:57 +0800 (CST) Received: from [127.0.0.1] (10.57.101.250) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.439.0; Tue, 20 Aug 2019 17:27:49 +0800 Subject: Re: [PATCH v3] gpio: pl061: Fix the issue failed to register the ACPI interrtupion To: Linus Walleij References: <1566221225-5170-1-git-send-email-xuwei5@hisilicon.com> CC: Salil Mehta , , Tangkunshan , "Liguozhu (Kenneth)" , "John Garry" , "Rafael J. Wysocki" , "linux-kernel@vger.kernel.org" , "Shameerali Kolothum Thodi" , Linuxarm , "open list:GPIO SUBSYSTEM" , Andy Shevchenko , huangdaode , Jonathan Cameron , Shiju Jose , "Mika Westerberg" , Zhangyi ac , Linux ARM , Len Brown From: Wei Xu Message-ID: <5D5BBD15.4030507@hisilicon.com> Date: Tue, 20 Aug 2019 17:27:49 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.57.101.250] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Linus, On 2019/8/20 16:01, Linus Walleij wrote: > On Mon, Aug 19, 2019 at 3:29 PM Wei Xu wrote: > >> Invoke acpi_gpiochip_request_interrupts after the acpi data has been >> attached to the pl061 acpi node to register interruption. >> >> Otherwise it will be failed to register interruption for the ACPI case. >> Because in the gpiochip_add_data_with_key, acpi_gpiochip_add is invoked >> after gpiochip_add_irqchip but at that time the acpi data has not been >> attached yet. > We need to fix this problem in gpiochip_add_data_with_key() instead. Thanks! Best Regards, Wei > Yours, > Linus Walleij > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > >