From: zhong jiang <zhongjiang@huawei.com>
To: zhong jiang <zhongjiang@huawei.com>
Cc: <bardliao@realtek.com>, <oder_chiou@realtek.com>,
<broonie@kernel.org>, <lgirdwood@gmail.com>, <perex@perex.cz>,
<tiwai@suse.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: rt5677: Make rt5677_spi_pcm_page static
Date: Tue, 29 Oct 2019 11:08:32 +0800 [thread overview]
Message-ID: <5DB7AD30.60007@huawei.com> (raw)
In-Reply-To: <1571919319-4205-1-git-send-email-zhongjiang@huawei.com>
ping.
On 2019/10/24 20:15, zhong jiang wrote:
> The GCC complains the following warning.
>
> sound/soc/codecs/rt5677-spi.c:365:13: warning: symbol 'rt5677_spi_pcm_page' was not declared. Should it be static?
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
> sound/soc/codecs/rt5677-spi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/codecs/rt5677-spi.c b/sound/soc/codecs/rt5677-spi.c
> index 36c02d2..b412371 100644
> --- a/sound/soc/codecs/rt5677-spi.c
> +++ b/sound/soc/codecs/rt5677-spi.c
> @@ -362,7 +362,7 @@ static void rt5677_spi_copy_work(struct work_struct *work)
> mutex_unlock(&rt5677_dsp->dma_lock);
> }
>
> -struct page *rt5677_spi_pcm_page(
> +static struct page *rt5677_spi_pcm_page(
> struct snd_soc_component *component,
> struct snd_pcm_substream *substream,
> unsigned long offset)
next prev parent reply other threads:[~2019-10-29 3:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 12:15 [PATCH] ASoC: rt5677: Make rt5677_spi_pcm_page static zhong jiang
2019-10-29 3:08 ` zhong jiang [this message]
2019-10-29 12:24 ` Mark Brown
[not found] ` <5DB8383C.7040601@huawei.com>
2019-10-29 13:09 ` Mark Brown
2019-10-31 13:20 ` Mark Brown
2019-10-31 13:40 ` zhong jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5DB7AD30.60007@huawei.com \
--to=zhongjiang@huawei.com \
--cc=bardliao@realtek.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oder_chiou@realtek.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox