* [PATCH] ASoC: rt5677: Make rt5677_spi_pcm_page static
@ 2019-10-24 12:15 zhong jiang
2019-10-29 3:08 ` zhong jiang
2019-10-31 13:20 ` Mark Brown
0 siblings, 2 replies; 6+ messages in thread
From: zhong jiang @ 2019-10-24 12:15 UTC (permalink / raw)
To: bardliao, oder_chiou, broonie
Cc: lgirdwood, perex, tiwai, linux-kernel, zhongjiang
The GCC complains the following warning.
sound/soc/codecs/rt5677-spi.c:365:13: warning: symbol 'rt5677_spi_pcm_page' was not declared. Should it be static?
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
sound/soc/codecs/rt5677-spi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/rt5677-spi.c b/sound/soc/codecs/rt5677-spi.c
index 36c02d2..b412371 100644
--- a/sound/soc/codecs/rt5677-spi.c
+++ b/sound/soc/codecs/rt5677-spi.c
@@ -362,7 +362,7 @@ static void rt5677_spi_copy_work(struct work_struct *work)
mutex_unlock(&rt5677_dsp->dma_lock);
}
-struct page *rt5677_spi_pcm_page(
+static struct page *rt5677_spi_pcm_page(
struct snd_soc_component *component,
struct snd_pcm_substream *substream,
unsigned long offset)
--
1.7.12.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: rt5677: Make rt5677_spi_pcm_page static
2019-10-24 12:15 [PATCH] ASoC: rt5677: Make rt5677_spi_pcm_page static zhong jiang
@ 2019-10-29 3:08 ` zhong jiang
2019-10-29 12:24 ` Mark Brown
2019-10-31 13:20 ` Mark Brown
1 sibling, 1 reply; 6+ messages in thread
From: zhong jiang @ 2019-10-29 3:08 UTC (permalink / raw)
To: zhong jiang
Cc: bardliao, oder_chiou, broonie, lgirdwood, perex, tiwai,
linux-kernel
ping.
On 2019/10/24 20:15, zhong jiang wrote:
> The GCC complains the following warning.
>
> sound/soc/codecs/rt5677-spi.c:365:13: warning: symbol 'rt5677_spi_pcm_page' was not declared. Should it be static?
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
> sound/soc/codecs/rt5677-spi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/codecs/rt5677-spi.c b/sound/soc/codecs/rt5677-spi.c
> index 36c02d2..b412371 100644
> --- a/sound/soc/codecs/rt5677-spi.c
> +++ b/sound/soc/codecs/rt5677-spi.c
> @@ -362,7 +362,7 @@ static void rt5677_spi_copy_work(struct work_struct *work)
> mutex_unlock(&rt5677_dsp->dma_lock);
> }
>
> -struct page *rt5677_spi_pcm_page(
> +static struct page *rt5677_spi_pcm_page(
> struct snd_soc_component *component,
> struct snd_pcm_substream *substream,
> unsigned long offset)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: rt5677: Make rt5677_spi_pcm_page static
2019-10-29 3:08 ` zhong jiang
@ 2019-10-29 12:24 ` Mark Brown
[not found] ` <5DB8383C.7040601@huawei.com>
0 siblings, 1 reply; 6+ messages in thread
From: Mark Brown @ 2019-10-29 12:24 UTC (permalink / raw)
To: zhong jiang; +Cc: bardliao, oder_chiou, lgirdwood, perex, tiwai, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 879 bytes --]
On Tue, Oct 29, 2019 at 11:08:32AM +0800, zhong jiang wrote:
> ping.
> On 2019/10/24 20:15, zhong jiang wrote:
Please don't send content free pings and please allow a reasonable time
for review. People get busy, go on holiday, attend conferences and so
on so unless there is some reason for urgency (like critical bug fixes)
please allow at least a couple of weeks for review. If there have been
review comments then people may be waiting for those to be addressed.
Sending content free pings adds to the mail volume (if they are seen at
all) which is often the problem and since they can't be reviewed
directly if something has gone wrong you'll have to resend the patches
anyway, so sending again is generally a better approach though there are
some other maintainers who like them - if in doubt look at how patches
for the subsystem are normally handled.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: rt5677: Make rt5677_spi_pcm_page static
2019-10-24 12:15 [PATCH] ASoC: rt5677: Make rt5677_spi_pcm_page static zhong jiang
2019-10-29 3:08 ` zhong jiang
@ 2019-10-31 13:20 ` Mark Brown
2019-10-31 13:40 ` zhong jiang
1 sibling, 1 reply; 6+ messages in thread
From: Mark Brown @ 2019-10-31 13:20 UTC (permalink / raw)
To: zhong jiang; +Cc: bardliao, oder_chiou, lgirdwood, perex, tiwai, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 293 bytes --]
On Thu, Oct 24, 2019 at 08:15:19PM +0800, zhong jiang wrote:
> The GCC complains the following warning.
>
> sound/soc/codecs/rt5677-spi.c:365:13: warning: symbol 'rt5677_spi_pcm_page' was not declared. Should it be static?
It looks like this has been fixed already in the latest code.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: rt5677: Make rt5677_spi_pcm_page static
2019-10-31 13:20 ` Mark Brown
@ 2019-10-31 13:40 ` zhong jiang
0 siblings, 0 replies; 6+ messages in thread
From: zhong jiang @ 2019-10-31 13:40 UTC (permalink / raw)
To: Mark Brown; +Cc: bardliao, oder_chiou, lgirdwood, perex, tiwai, linux-kernel
On 2019/10/31 21:20, Mark Brown wrote:
> On Thu, Oct 24, 2019 at 08:15:19PM +0800, zhong jiang wrote:
>> The GCC complains the following warning.
>>
>> sound/soc/codecs/rt5677-spi.c:365:13: warning: symbol 'rt5677_spi_pcm_page' was not declared. Should it be static?
> It looks like this has been fixed already in the latest code.
Yes, I has noticed that.
Thanks,
zhong jiang
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-10-31 13:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-24 12:15 [PATCH] ASoC: rt5677: Make rt5677_spi_pcm_page static zhong jiang
2019-10-29 3:08 ` zhong jiang
2019-10-29 12:24 ` Mark Brown
[not found] ` <5DB8383C.7040601@huawei.com>
2019-10-29 13:09 ` Mark Brown
2019-10-31 13:20 ` Mark Brown
2019-10-31 13:40 ` zhong jiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox