From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 997BFC43603 for ; Mon, 16 Dec 2019 13:36:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 70135206CB for ; Mon, 16 Dec 2019 13:36:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727936AbfLPNgR (ORCPT ); Mon, 16 Dec 2019 08:36:17 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:7252 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727834AbfLPNgR (ORCPT ); Mon, 16 Dec 2019 08:36:17 -0500 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 64F7A3C6DE9BC06E0313; Mon, 16 Dec 2019 21:36:15 +0800 (CST) Received: from [127.0.0.1] (10.133.219.218) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.439.0; Mon, 16 Dec 2019 21:36:13 +0800 Message-ID: <5DF7884C.1040108@huawei.com> Date: Mon, 16 Dec 2019 21:36:12 +0800 From: zhong jiang User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: "Andrew F. Davis" CC: , , , , , , , Subject: Re: [PATCH] dma-heap: Make the symbol 'dma_heap_ioctl_cmds' static References: <1576490904-18069-1-git-send-email-zhongjiang@huawei.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.133.219.218] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/12/16 21:01, Andrew F. Davis wrote: > On 12/16/19 5:08 AM, zhong jiang wrote: >> Fix the following sparse warning. >> >> drivers/gpu/drm/ast/ast_main.c:391:22: warning: symbol 'ast_mode_config_mode_valid' was not declared. Should it be static? >> > > The patch looks valid, but this commit message does not seem to match.. Sorry for stupid mistake. Will repost it in v2. Thanks, zhong jiang > > Andrew > > >> Signed-off-by: zhong jiang >> --- >> drivers/dma-buf/dma-heap.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/dma-buf/dma-heap.c b/drivers/dma-buf/dma-heap.c >> index 4f04d10..da2090e 100644 >> --- a/drivers/dma-buf/dma-heap.c >> +++ b/drivers/dma-buf/dma-heap.c >> @@ -106,7 +106,7 @@ static long dma_heap_ioctl_allocate(struct file *file, void *data) >> return 0; >> } >> >> -unsigned int dma_heap_ioctl_cmds[] = { >> +static unsigned int dma_heap_ioctl_cmds[] = { >> DMA_HEAP_IOC_ALLOC, >> }; >> >> > . >