public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Xiao Yang <yangx.jy@cn.fujitsu.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Markus Elfring <Markus.Elfring@web.de>,
	<linux-kselftest@vger.kernel.org>,
	<linux-trace-devel@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@redhat.com>,
	Xiao Yang <ice_yangxiao@163.com>
Subject: Re: [PATCH v2] tracing: Fix the race between registering 'snapshot' event trigger and triggering 'snapshot' operation
Date: Wed, 15 Apr 2020 09:59:40 +0800	[thread overview]
Message-ID: <5E966A8C.2010000@cn.fujitsu.com> (raw)
In-Reply-To: <20200414214643.2e14ac76@oasis.local.home>

On 2020/4/15 9:46, Steven Rostedt wrote:
> On Wed, 15 Apr 2020 09:40:20 +0800
> Xiao Yang<yangx.jy@cn.fujitsu.com>  wrote:
>
>> On 2020/4/14 15:54, Markus Elfring wrote:
>>>> Traced event can trigger 'snapshot' operation(i.e. calls snapshot_trigger()
>>>
>>> I suggest to improve the change description.
>>>
>>> * Adjustment:
>>>     … operation (i. e. …
>> Hi Markus,
>>
>> Which part of description do you want to change or could you provide an
>> example for reference?
>
> That part is fine for me.
>
>>
>>>
>>> * Will the tag “Fixes” become relevant?
>>
>> Do you mean to add the following "Fixes" tag?
>> Fixes: 93e31ffbf417 "tracing: Add 'snapshot' event trigger command"
>>
>
> Yeah, that fixes tag is appropriate. But I usually add those myself, you
> don't need to resend.
Hi Steven,

Thanks for your quick reply.
Got it and I will keep the v2 patch.

Thanks,
Xiao Yang
>
> -- Steve
>
>
> .
>




  reply	other threads:[~2020-04-15  1:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-14  7:54 [PATCH v2] tracing: Fix the race between registering 'snapshot' event trigger and triggering 'snapshot' operation Markus Elfring
2020-04-15  1:40 ` Xiao Yang
2020-04-15  1:46   ` Steven Rostedt
2020-04-15  1:59     ` Xiao Yang [this message]
2020-04-15  7:12     ` [v2] " Markus Elfring
  -- strict thread matches above, loose matches on Subject: below --
2020-04-14  1:51 [PATCH v2] " Xiao Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5E966A8C.2010000@cn.fujitsu.com \
    --to=yangx.jy@cn.fujitsu.com \
    --cc=Markus.Elfring@web.de \
    --cc=ice_yangxiao@163.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox