From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 313CEC433E0 for ; Fri, 31 Jul 2020 02:41:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0A8362083E for ; Fri, 31 Jul 2020 02:41:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731231AbgGaClE (ORCPT ); Thu, 30 Jul 2020 22:41:04 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:45440 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730820AbgGaClE (ORCPT ); Thu, 30 Jul 2020 22:41:04 -0400 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 3DAB5CA23216DB556543; Fri, 31 Jul 2020 10:41:00 +0800 (CST) Received: from [10.63.139.185] (10.63.139.185) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.487.0; Fri, 31 Jul 2020 10:40:49 +0800 Subject: Re: [PATCH] uacce: fix some coding styles To: Kai Ye , , , , References: <1596089583-32687-1-git-send-email-yekai13@huawei.com> From: Zhou Wang Message-ID: <5F2384B1.3040301@hisilicon.com> Date: Fri, 31 Jul 2020 10:40:49 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1596089583-32687-1-git-send-email-yekai13@huawei.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.63.139.185] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/7/30 14:13, Kai Ye wrote: > 1. delete some redundant code. > 2. modify the module author information. > > Signed-off-by: Kai Ye Fine to me. Reviewed-by: Zhou Wang Thanks, Zhou > --- > Changes in V2: > deleted extra NULL pointer check in uacce_fops. > > drivers/misc/uacce/uacce.c | 13 +------------ > 1 file changed, 1 insertion(+), 12 deletions(-) > > diff --git a/drivers/misc/uacce/uacce.c b/drivers/misc/uacce/uacce.c > index 107028e..1d09707 100644 > --- a/drivers/misc/uacce/uacce.c > +++ b/drivers/misc/uacce/uacce.c > @@ -239,17 +239,6 @@ static int uacce_fops_mmap(struct file *filep, struct vm_area_struct *vma) > > switch (type) { > case UACCE_QFRT_MMIO: > - if (!uacce->ops->mmap) { > - ret = -EINVAL; > - goto out_with_lock; > - } > - > - ret = uacce->ops->mmap(q, vma, qfr); > - if (ret) > - goto out_with_lock; > - > - break; > - > case UACCE_QFRT_DUS: > if (!uacce->ops->mmap) { > ret = -EINVAL; > @@ -541,5 +530,5 @@ subsys_initcall(uacce_init); > module_exit(uacce_exit); > > MODULE_LICENSE("GPL"); > -MODULE_AUTHOR("Hisilicon Tech. Co., Ltd."); > +MODULE_AUTHOR("HiSilicon Tech. Co., Ltd."); > MODULE_DESCRIPTION("Accelerator interface for Userland applications"); >