From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2655C2D0A7 for ; Thu, 10 Sep 2020 09:30:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7CD9421582 for ; Thu, 10 Sep 2020 09:30:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730354AbgIJJaX (ORCPT ); Thu, 10 Sep 2020 05:30:23 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:54732 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726760AbgIJJ3G (ORCPT ); Thu, 10 Sep 2020 05:29:06 -0400 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 3A488CCA989BC0EEEE23; Thu, 10 Sep 2020 17:29:00 +0800 (CST) Received: from [10.174.178.248] (10.174.178.248) by smtp.huawei.com (10.3.19.206) with Microsoft SMTP Server (TLS) id 14.3.487.0; Thu, 10 Sep 2020 17:28:52 +0800 Subject: Re: [PATCH] clk: qcom: lpass: Correct goto target in lpass_core_sc7180_probe() To: Stephen Boyd , , , , References: <20200827141629.101802-1-jingxiangfeng@huawei.com> <159972862952.2295844.10882678924928944990@swboyd.mtv.corp.google.com> CC: , , From: Jing Xiangfeng Message-ID: <5F59F1D3.50905@huawei.com> Date: Thu, 10 Sep 2020 17:28:51 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <159972862952.2295844.10882678924928944990@swboyd.mtv.corp.google.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.248] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/9/10 17:03, Stephen Boyd wrote: > Quoting Jing Xiangfeng (2020-08-27 07:16:29) >> lpass_core_sc7180_probe() misses to call pm_clk_destroy() and >> pm_runtime_disable() in error paths. Correct goto target to fix it. >> This issue is found by code inspection. >> >> Signed-off-by: Jing Xiangfeng >> --- > > HMm.. presumably > > Fixes: edab812d802d ("clk: qcom: lpass: Add support for LPASS clock controller for SC7180") > > should be added? Ok, I will send a v2 with it. Thanks > . >