From: Xiaofei Tan <tanxiaofei@huawei.com>
To: <dsterba@suse.cz>, <clm@fb.com>, <josef@toxicpanda.com>,
<dsterba@suse.com>, <linux-btrfs@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linuxarm@huawei.com>
Subject: Re: [PATCH] btrfs: block-group: fix a doc warning in block-group.c
Date: Fri, 25 Sep 2020 16:21:06 +0800 [thread overview]
Message-ID: <5F6DA872.7000504@huawei.com> (raw)
In-Reply-To: <20200923094543.GL6756@twin.jikos.cz>
Hi David,
On 2020/9/23 17:45, David Sterba wrote:
> On Tue, Sep 22, 2020 at 08:37:21PM +0800, Xiaofei Tan wrote:
>> Fix following warning caused by mismatch bewteen function parameters
>> and comments.
>> fs/btrfs/block-group.c:1649: warning: Function parameter or member 'fs_info' not described in 'btrfs_rmap_block'
>
> IIRC there are way more formatting errors for the kernel-doc, so I'd
> rather fix them in one patch. Also for static functions or internal
> helpers the proper formatting is not that important as it's read by
> people and the acual parameters are what matters.
>
Sure, there are many warnings in the other files from dir fs/btrfs/.
If fix them in one patch, it could be huge :)
> .
>
--
thanks
tanxiaofei
prev parent reply other threads:[~2020-09-25 8:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 12:37 [PATCH] btrfs: block-group: fix a doc warning in block-group.c Xiaofei Tan
2020-09-23 9:45 ` David Sterba
2020-09-25 8:21 ` Xiaofei Tan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5F6DA872.7000504@huawei.com \
--to=tanxiaofei@huawei.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox