From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B26DAC00A89 for ; Mon, 2 Nov 2020 07:37:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7287820719 for ; Mon, 2 Nov 2020 07:37:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728141AbgKBHhU (ORCPT ); Mon, 2 Nov 2020 02:37:20 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:6725 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728029AbgKBHhU (ORCPT ); Mon, 2 Nov 2020 02:37:20 -0500 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4CPl9k5112zkdRv; Mon, 2 Nov 2020 15:37:14 +0800 (CST) Received: from [10.63.139.185] (10.63.139.185) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.487.0; Mon, 2 Nov 2020 15:37:10 +0800 Subject: Re: [PATCH v3 1/2] uacce: delete some redundant code. To: Kai Ye , , , , , Greg Kroah-Hartman References: <1600855762-10031-1-git-send-email-yekai13@huawei.com> <1600855762-10031-2-git-send-email-yekai13@huawei.com> From: Zhou Wang Message-ID: <5F9FB725.5000002@hisilicon.com> Date: Mon, 2 Nov 2020 15:37:09 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1600855762-10031-2-git-send-email-yekai13@huawei.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.63.139.185] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/9/23 18:09, Kai Ye wrote: > Delete some redundant code. > > Signed-off-by: Kai Ye > Reviewed-by: Zhou Wang > Reviewed-by: Jonathan Cameron > Acked-by: Zhangfei Gao > --- > drivers/misc/uacce/uacce.c | 11 ----------- > 1 file changed, 11 deletions(-) > > diff --git a/drivers/misc/uacce/uacce.c b/drivers/misc/uacce/uacce.c > index 107028e..9b83bc5 100644 > --- a/drivers/misc/uacce/uacce.c > +++ b/drivers/misc/uacce/uacce.c > @@ -239,17 +239,6 @@ static int uacce_fops_mmap(struct file *filep, struct vm_area_struct *vma) > > switch (type) { > case UACCE_QFRT_MMIO: > - if (!uacce->ops->mmap) { > - ret = -EINVAL; > - goto out_with_lock; > - } > - > - ret = uacce->ops->mmap(q, vma, qfr); > - if (ret) > - goto out_with_lock; > - > - break; > - > case UACCE_QFRT_DUS: > if (!uacce->ops->mmap) { > ret = -EINVAL; > Hi Hartman, Could you take this patch? Best, Zhou