Re: [Bug #13660] Crashes during boot on 2.6.30 / 2.6.31-rc, random programs

Américo Wang
2009-07-07T14:06:05Z

On Thu, Jul 2, 2009 at 4:36 AM, Joao Correia<joaomiguelcorreia@gmail.com> wrote:
> No formal patch has been sent yet, that i am aware of. I have made
> some changes following suggestion by Americo Wang advise, to the
> following:
>
> (patch by Ingo)
>
> diff --git a/kernel/lockdep_internals.h b/kernel/lockdep_internals.h
> index 699a2ac..031f4c6 100644
> --- a/kernel/lockdep_internals.h
> +++ b/kernel/lockdep_internals.h
> @@ -65,7 +65,7 @@ enum {
>  * Stack-trace: tightly packed array of stack backtrace
>  * addresses. Protected by the hash_lock.
>  */
> -#define MAX_STACK_TRACE_ENTRIES        262144UL
> +#define MAX_STACK_TRACE_ENTRIES        1048576UL
>
>  extern struct list_head all_lock_classes;
>  extern struct lock_chain lock_chains[];
>
> and afterwards, a new bug popped up, solved by changing
>
> include/linux/sched.h
>
> # define MAX_LOCK_DEPTH 48UL
>
> to
>
> # define MAX_LOCK_DEPTH 96UL
>
>
> I have now found a third limit bug, related to MAX_LOCKDEP_CHAINS,
> which was hidden so far, which im trying to raise and replicate. This
> is being discussed in detail in another message exchange on the lkml,
> between me and Americo.

How about changing MAX_LOCKDEP_CHAINS_BITS to 16?

kernel/lockdep_internals.h:59:#define MAX_LOCKDEP_CHAINS_BITS 15

And can you make a complete patch and send it to lkml with Peter and me
Cc'ed?

Thank you!