Re: [Bug #13663] suspend to ram regression (IDE related)

Bartlomiej Zolnierkiewicz
2009-06-29T17:40:21Z

On Monday 29 June 2009 17:51:35 Etienne Basset wrote:
> David Miller wrote:
> > From: Etienne Basset <etienne.basset@numericable.fr>
> > Date: Mon, 29 Jun 2009 12:29:09 +0200
> >
> >> yes, patch is not yet upstream;
> >
> > I'll take care of pushing this around today.
> >
> Hi,
>
> thank you ;
> i ran a new bisection to identify the commit that cause pain after -rc1
>
> etienne@etienne-desktop:~/linux-2.6$ git bisect good
> a1317f714af7aed60ddc182d0122477cbe36ee9b is first bad commit

Thanks for finding it.

Dave, please just revert this patch (it wasn't meant for Linus' tree anyway).

> commit a1317f714af7aed60ddc182d0122477cbe36ee9b
> Author: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Date: Tue Jun 23 23:52:17 2009 -0700
>
> ide: improve handling of Power Management requests
>
> Make hwif->rq point to PM request during PM sequence and do not allow
> any other types of requests to slip in (the old comment was never correct
> as there should be no such requests generated during PM sequence).
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Signed-off-by: David S. Miller <davem@davemloft.net>
>
> To have STR/resume work with current git, I have to :
> 1) apply Bart's patch
> 2) revert this commit : a1317f714af7aed60ddc182d0122477cbe36ee9b
>
> thanks
> Etienne
>
>