From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E93C93E2759 for ; Mon, 4 May 2026 18:42:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777920138; cv=none; b=C2djisvMNu00KDcG04UHXNmPkBcXG6iFj9+b+BZLJKJZQI1MHZ/ilhPsl+7JmdRweUYpk+2i5anRZixOho/2+M+AaDal+MdAeLqqbik0sr6ZOSACDL9ce+W0lbUpdHMO15sTdUXRiANE/EQ49hVIRYRIzL1syXYBoyN5BGN3eWc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777920138; c=relaxed/simple; bh=jJfQt3VZGm/nHKrH3uy6JIqEnWmTy7Ym/jOoMpMuHcY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OaLRwLa3F1Nn0yf865YUhYlL82bZ/3jHdcKFsptU5h30//I8kZPj76fyD7nyZllSlJZ+wxq5GPbIStDMtPhP4lbxzUQxvR7dnD0Abz02Urc1fU7f/VQSmuqxQMYmAHVLWlPfrLXQFE9F0Wd7kzfDD/JjiT+WHn4/VB1n9ppogwU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=Isi/X9Dm; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="Isi/X9Dm" Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 644Ee7K53279333; Mon, 4 May 2026 18:41:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=yvHcsN FjpKdX5ErIocbgAVaHl/9juTjsjhDQtOgugvw=; b=Isi/X9DmTiz++beZ2hHnz0 lnO7FKsu3Q3rdfK+tbMMMBKCWqzQL+RwsLDBek71bzhUiNku1uQkwEosES1aJ7OO VcNDGIjP/DT+fHX/WbbgHTk30PkSxkttmSXPHI5Qvproqy/eLoqfHswSIlVsCn9t NxSBuoyMqqCDIYoKDaaVPk4f8iwD5ERXbuyZ+TbwLE1lVr6yDec/b8FeSQxWW+P/ 7M6N6TBOSLmchINLDM7BTALXSkhPKQTRNL8LDiarkapodkv7Gk/QjvZGrGQxCZIt F6xY+OJ+aQk5aVhaSn9ZUEN5pSv2YoEmabDmAvBWf3FMtZsaL+pPv+huaATaYP8w == Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4dw9xxg6an-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 04 May 2026 18:41:32 +0000 (GMT) Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 644IdYZq029391; Mon, 4 May 2026 18:41:31 GMT Received: from smtprelay06.wdc07v.mail.ibm.com ([172.16.1.73]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 4dwukq6hvj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 04 May 2026 18:41:31 +0000 (GMT) Received: from smtpav04.wdc07v.mail.ibm.com (smtpav04.wdc07v.mail.ibm.com [10.39.53.231]) by smtprelay06.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 644IfUxu31523576 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 4 May 2026 18:41:30 GMT Received: from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 653DD58052; Mon, 4 May 2026 18:41:30 +0000 (GMT) Received: from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 421F858045; Mon, 4 May 2026 18:41:11 +0000 (GMT) Received: from [9.124.220.160] (unknown [9.124.220.160]) by smtpav04.wdc07v.mail.ibm.com (Postfix) with ESMTP; Mon, 4 May 2026 18:41:10 +0000 (GMT) Message-ID: <5a01bf62-772c-461d-a7ae-ce4758a3fc5b@linux.ibm.com> Date: Tue, 5 May 2026 00:11:09 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 4/7] mm: pghot: Precision mode for pghot To: Bharata B Rao , linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: Jonathan.Cameron@huawei.com, dave.hansen@intel.com, gourry@gourry.net, mgorman@techsingularity.net, mingo@redhat.com, peterz@infradead.org, raghavendra.kt@amd.com, riel@surriel.com, rientjes@google.com, sj@kernel.org, weixugc@google.com, willy@infradead.org, ying.huang@linux.alibaba.com, ziy@nvidia.com, dave@stgolabs.net, nifan.cxl@gmail.com, xuezhengchu@huawei.com, yiannis@zptcorp.com, akpm@linux-foundation.org, david@kernel.org, byungchul@sk.com, kinseyho@google.com, joshua.hahnjy@gmail.com, yuanchu@google.com, balbirs@nvidia.com, alok.rathore@samsung.com, shivankg@amd.com References: <20260504060924.344313-1-bharata@amd.com> <20260504060924.344313-5-bharata@amd.com> Content-Language: en-US From: Donet Tom In-Reply-To: <20260504060924.344313-5-bharata@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA0MDE3MCBTYWx0ZWRfX3eQGrXRcx67y Q+qDSY+an09rUR5bUgGyBsHUpGRRy9Ty3c4Fuekq4vlPqG9Jg3/rliCNYyDdjG276jSRSucXTR1 lorAJy5aD1ychZhtQ/0TwzCQl8d5bizJ6zmGL+3buTi+iFF3bU8RWokeJJ+reSdx1bdpS8K/KNT VD8vP6cXKcfsacizEWnbBAgpLBRRwDng6VMleHIYlHj7f4iSHaFK3KrdQ8hK/aBQgIW+V57g5zt sKZOMwfVQ1bC8tpFdysMc+Zag1qwzwGKERa2JJORKUQTxtOH/1yJxHvHLyWq/oA/+8ZrzTbGFTi fnO6qW5fS3AnBl13+ZuFSatcNnwvk/wNuR6DSvoyIMmUOL26DHOfafAlqfYRD4d0nbz3xLwJuw7 tS57rPouG27WFmBHX9NcbFwxtkd8aQe+ZW2g2DGoMHb9AKzTNpr2MRiO40sCsyrQ0IeHg4Ed46U akp2RreXGpZbNrlLeVg== X-Proofpoint-ORIG-GUID: tnQ7oG-l8PShrukvXVgQiQl63R7FB0zx X-Proofpoint-GUID: -h9KWz6Den0bubtBzScitqzim355Tuff X-Authority-Analysis: v=2.4 cv=ctWrVV4i c=1 sm=1 tr=0 ts=69f8e85c cx=c_pps a=bLidbwmWQ0KltjZqbj+ezA==:117 a=bLidbwmWQ0KltjZqbj+ezA==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=V8glGbnc2Ofi9Qvn3v5h:22 a=7u06FiZDblvXUniig18A:9 a=QEXdDO2ut3YA:10 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-04_05,2026-04-30_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 clxscore=1015 suspectscore=0 impostorscore=0 spamscore=0 malwarescore=0 phishscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605040170 Hi Bharata On 5/4/26 11:39 AM, Bharata B Rao wrote: > +#include > +#include > +#include > + > +bool pghot_nid_valid(int nid) I might be missing something, but since pghot_nid_valid() exists in both pghot-default.c and pghot-precise.c, would it make sense to move it to a header file as a static inline function? -Donet > +{ > + if (nid != NUMA_NO_NODE && > + (!numa_valid_node(nid) || nid > PGHOT_NID_MAX || > + !node_online(nid) || !node_is_toptier(nid))) > + return false; > + > + return true; > +} > + > +unsigned long pghot_access_latency(unsigned long old_time, unsigned long time) > +{ > + return jiffies_to_msecs((time - old_time) & PGHOT_TIME_MASK); > +} > + > +bool pghot_update_record(phi_t *phi, int nid, unsigned long now) > +{