From: Paolo Abeni <pabeni@redhat.com>
To: Bernd Edlinger <bernd.edlinger@hotmail.de>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: stmmac: Wait a bit for the reset to take effect
Date: Thu, 02 Nov 2023 12:25:07 +0100 [thread overview]
Message-ID: <5a265e5541ab1de2258a6e61bd672ef5fb6be65f.camel@redhat.com> (raw)
In-Reply-To: <AS8P193MB1285DECD77863E02EF45828BE4A1A@AS8P193MB1285.EURP193.PROD.OUTLOOK.COM>
On Mon, 2023-10-30 at 07:01 +0100, Bernd Edlinger wrote:
> otherwise the synopsys_id value may be read out wrong,
> because the GMAC_VERSION register might still be in reset
> state, for at least 1 us after the reset is de-asserted.
>
> Add a wait for 10 us before continuing to be on the safe side.
This looks like a bugfix: you should target explicitly the 'net' tree,
adding such tag into the subj. More importantly you should include a
suitable 'Fixes' tag.
Please send a new revision with the above changes. You can retain the
already collected reviewed tags.
Thanks,
Paolo
next prev parent reply other threads:[~2023-11-02 11:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-30 6:01 [PATCH] net: stmmac: Wait a bit for the reset to take effect Bernd Edlinger
2023-10-30 11:55 ` Jiri Pirko
2023-10-31 10:32 ` Serge Semin
2023-10-31 16:10 ` Bernd Edlinger
2023-11-02 12:03 ` Serge Semin
2023-11-02 11:25 ` Paolo Abeni [this message]
2023-11-03 10:45 ` Bernd Edlinger
2024-01-15 19:21 ` [PATCH v2] " Bernd Edlinger
2024-01-16 12:22 ` Paolo Abeni
2024-01-17 16:36 ` Bernd Edlinger
2024-01-19 10:27 ` Bernd Edlinger
2024-01-19 11:42 ` Paolo Abeni
2024-01-16 22:35 ` Andrew Lunn
2024-01-17 16:48 ` Bernd Edlinger
2024-01-17 16:55 ` Jose Abreu
2024-01-19 7:15 ` Bernd Edlinger
2024-01-19 10:38 ` Jose Abreu
2024-01-22 6:41 ` Bernd Edlinger
2024-01-22 15:44 ` Jose Abreu
2024-01-22 18:19 ` [PATCH net v3] " Bernd Edlinger
2024-01-24 13:31 ` Serge Semin
2024-01-24 20:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a265e5541ab1de2258a6e61bd672ef5fb6be65f.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=alexandre.torgue@foss.st.com \
--cc=bernd.edlinger@hotmail.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).