From: "Christian König" <christian.koenig@amd.com>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: ray.huang@amd.com, airlied@linux.ie, daniel@ffwll.ch,
sumit.semwal@linaro.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linaro-mm-sig@lists.linaro.org
Subject: Re: [PATCH] drm/ttm/ttm_bo: make ttm_bo_glob_use_count static
Date: Tue, 23 Feb 2021 10:18:40 +0100 [thread overview]
Message-ID: <5a2f3ed1-2867-25af-bb9b-51d99ef66d28@amd.com> (raw)
In-Reply-To: <1614070452-91054-1-git-send-email-jiapeng.chong@linux.alibaba.com>
Am 23.02.21 um 09:54 schrieb Jiapeng Chong:
> Fix the following sparse warning:
>
> drivers/gpu/drm/ttm/ttm_bo.c:53:10: warning: symbol
> 'ttm_bo_glob_use_count' was not declared. Should it be static?
IIRC we already have a patch for this on the mailing list and the mutex
can be static as well.
Christian.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/gpu/drm/ttm/ttm_bo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
> index b65f4b1..107dd13 100644
> --- a/drivers/gpu/drm/ttm/ttm_bo.c
> +++ b/drivers/gpu/drm/ttm/ttm_bo.c
> @@ -50,7 +50,7 @@
> * ttm_global_mutex - protecting the global BO state
> */
> DEFINE_MUTEX(ttm_global_mutex);
> -unsigned ttm_bo_glob_use_count;
> +static unsigned ttm_bo_glob_use_count;
> struct ttm_bo_global ttm_bo_glob;
> EXPORT_SYMBOL(ttm_bo_glob);
>
prev parent reply other threads:[~2021-02-23 9:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 8:54 [PATCH] drm/ttm/ttm_bo: make ttm_bo_glob_use_count static Jiapeng Chong
2021-02-23 9:18 ` Christian König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a2f3ed1-2867-25af-bb9b-51d99ef66d28@amd.com \
--to=christian.koenig@amd.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=ray.huang@amd.com \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox