Re: [PATCH v5 2/6] cxl/events: Add Component Identifier formatting for CXL spec rev 3.1

Ira Weiny
2025-01-10T17:43:36Z

shiju.jose@ wrote:
> From: Shiju Jose <shiju.jose@huawei.com>
>
> Add Component Identifier formatting for CXL spec rev 3.1, Section
> 8.2.9.2.1, Table 8-44.
>
> Examples for Component Identifier format in trace log,
>
> validity_flags='CHANNEL|RANK|DEVICE|COMPONENT|COMPONENT PLDM FORMAT' \
> comp_id=03 74 c5 08 9a 1a 0b fc d2 7e 2f 31 9b 3c 81 4d \
> comp_id_pldm_valid_flags='PLDM Entity ID | Resource ID' \
> pldm_entity_id=74 c5 08 9a 1a 0b pldm_resource_id=fc d2 7e 2f \
>
> validity_flags='COMPONENT|COMPONENT PLDM FORMAT' \
> comp_id=02 74 c5 08 9a 1a 0b fc d2 7e 2f 31 9b 3c 81 4d \
> comp_id_pldm_valid_flags='Resource ID' \
> pldm_entity_id=0x00 pldm_resource_id=fc d2 7e 2f
>
> If the validity flags for component ID/component ID format or PLDM ID or
> resource ID are not set, then pldm_entity_id=0x00 or pldm_resource_id=0x00
> would be printed.

NIT: I would have mentioned that these are used in subsequent patches...
But...

Reviewed-by: Ira Weiny <ira.weiny@intel.com>

[snip]