Re: [PATCH v3 4/7] selftests/ftrace: Convert required interface checks into requires list

[Shuah Khan <skhan@linuxfoundation.org>]

On 6/9/20 11:55 PM, Masami Hiramatsu wrote:
> Hi Shuah,
> 
> On Tue, 9 Jun 2020 14:41:27 -0600
> Shuah Khan <skhan@linuxfoundation.org> wrote:
> 
>> On 6/2/20 8:40 PM, Masami Hiramatsu wrote:
>>> Convert the required tracefs interface checking code with
>>> requires: list.
>>>
>>> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
>>> Reviewed-by: Tom Zanussi <zanussi@kernel.org>
>>> ---
>>>     Changes in v2: Fix trigger-onchange-action-hist.tc requires list.
>>
>> Masami,
>>
>> This patch doesn't apply to linux-kselftest next
>>
>> Patches 1-3 applied fine and this one failed. For now I will
>> hold off on applying this series.
> 
> Yes, there is another patch posted by Tom with his ftrace enhancement
> in tracing-next. Thus I commented on 0/7 as below.
> 

Sorry I made a note of it when I first looked at the series and
missed that when I was applying patches.

> ----
> Since this series depends on following 2 commits,
> 
> commit 619ee76f5c9f ("selftests/ftrace: Return unsupported if no
>   error_log file") on Shuah's Kselftest tree
> commit bea24f766efc ("selftests/ftrace: Distinguish between hist
>   and synthetic event checks") on Steven's Tracing tree
> 
> This can be applied on the tree which merged both of them.
> ----
> 
> I'm not sure how do I handle it. It is OK just modifying this
> for linux-kselftest, but in that case we will need another
> patch after merged both.
> 
> IMHO, since the kselftest must run correctly on older kernel,
> (and ftracetest does) Tom's kselftest patch should be merged
> into linux-kselftest instead of tracing tree.
> 
> Steve, what would you think?
> 

No worries. As far as kselftest tree is concrned, I can apply these
after rc1 comes out with Tom's patch.

Or I can give Ack and Steve can take these through tracing tree.


thanks,
-- Shuah