From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31999C433E1 for ; Wed, 10 Jun 2020 12:04:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0480F2074B for ; Wed, 10 Jun 2020 12:04:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591790682; bh=22bjNNW6PhxbuqZXDp4o1X12PbTFyaBJ/e14OWvZ9p8=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=KvKY45nyD1lKegWfFelxW0gnntvayKrIxlxvQeYdOxXHk0PC2owRqPnaF8pizDhih mwFE+/DW51UZgl1LJ5DpfHSgWbDb+jL4MpzTHprYGqph9Y2LGDPatpWV64vM0SCIRM qPvV7WyT8p7xesBNw8k2KhEW0FKH/cwupkLvQQnc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728893AbgFJMEk (ORCPT ); Wed, 10 Jun 2020 08:04:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41196 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728647AbgFJMEi (ORCPT ); Wed, 10 Jun 2020 08:04:38 -0400 Received: from mail-ot1-x342.google.com (mail-ot1-x342.google.com [IPv6:2607:f8b0:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72FD3C03E96B for ; Wed, 10 Jun 2020 05:04:36 -0700 (PDT) Received: by mail-ot1-x342.google.com with SMTP id 97so1499631otg.3 for ; Wed, 10 Jun 2020 05:04:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=hDQ1f7GxgIenpnrfjjsSwEQqXFg9qmR/mq8VF3wwVUw=; b=U0TFHza/mFwgCdbNAv5y57CHubhJ88QTZKe9L3Vs3W+l/4+m27dDr7hIOoieGo37tf TtsHk5+lewifx8kIHPNKwzjN+HCJLMhzwWH3zBeW8zmYCJ53/zWq8MNsMMf8FvqSXPXw 3vLmGQYass+cSLWRudAMX9WLj8fJChZoc3FgE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hDQ1f7GxgIenpnrfjjsSwEQqXFg9qmR/mq8VF3wwVUw=; b=RI+BepE+YPWsKztfEKZrctBbU9v1vbGKP/4bQZOuw7t/MMOndkMAlsMPBnRx0SCbJN lI0etVfsrxh9cjeEQpK3wm0ijALV5u1L6oTnH5BTjHkIIxQNuSyXfHI3+2tpDJ8vE8iE /GEZf7z65QouExvKipGAeFauN5NqGeiKdX5cBl8VuR+8aS8a/ilXdFcEgiKzWYWf+xPe xUOVi+6rKLjcwWBVfzBy0MTqu3sqU4chutOzsrabQgNYgvjw95KgznsY14ArZCzhtzm3 osw7G5whNMSbICn1Xxcpynx1F1bZc8N38YmRA+WGpgREdrAazIPdjavuCqDq07TP8wUw Q56A== X-Gm-Message-State: AOAM5309QToOoISn6yYJImf5KLMJtxCOwDIz+YsHupho+gai7G64c+90 MytOVsByodvwN3RUrHB6c162pQ== X-Google-Smtp-Source: ABdhPJwyIl3tV0H71EcAz7e72pJ1J+W64/fKEusa03TZIBDnAl5bReM9AsiTKcLQgDj8CoAwE2SQfA== X-Received: by 2002:a9d:d86:: with SMTP id 6mr2460944ots.83.1591790675575; Wed, 10 Jun 2020 05:04:35 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id q2sm2841277oti.36.2020.06.10.05.04.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Jun 2020 05:04:34 -0700 (PDT) Subject: Re: [PATCH v3 4/7] selftests/ftrace: Convert required interface checks into requires list To: Masami Hiramatsu Cc: Steven Rostedt , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan , Tom Zanussi , Shuah Khan References: <159115200085.70027.6141550347953439240.stgit@devnote2> <159115203782.70027.2241223276591824366.stgit@devnote2> <1cf646af-ef25-a7df-9df3-1e6aa8e6a9c8@linuxfoundation.org> <20200610145535.747d2765d60e6e3923441768@kernel.org> From: Shuah Khan Message-ID: <5a658ffa-348a-436d-fb74-e01f56541d6b@linuxfoundation.org> Date: Wed, 10 Jun 2020 06:04:33 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200610145535.747d2765d60e6e3923441768@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/9/20 11:55 PM, Masami Hiramatsu wrote: > Hi Shuah, > > On Tue, 9 Jun 2020 14:41:27 -0600 > Shuah Khan wrote: > >> On 6/2/20 8:40 PM, Masami Hiramatsu wrote: >>> Convert the required tracefs interface checking code with >>> requires: list. >>> >>> Signed-off-by: Masami Hiramatsu >>> Reviewed-by: Tom Zanussi >>> --- >>> Changes in v2: Fix trigger-onchange-action-hist.tc requires list. >> >> Masami, >> >> This patch doesn't apply to linux-kselftest next >> >> Patches 1-3 applied fine and this one failed. For now I will >> hold off on applying this series. > > Yes, there is another patch posted by Tom with his ftrace enhancement > in tracing-next. Thus I commented on 0/7 as below. > Sorry I made a note of it when I first looked at the series and missed that when I was applying patches. > ---- > Since this series depends on following 2 commits, > > commit 619ee76f5c9f ("selftests/ftrace: Return unsupported if no > error_log file") on Shuah's Kselftest tree > commit bea24f766efc ("selftests/ftrace: Distinguish between hist > and synthetic event checks") on Steven's Tracing tree > > This can be applied on the tree which merged both of them. > ---- > > I'm not sure how do I handle it. It is OK just modifying this > for linux-kselftest, but in that case we will need another > patch after merged both. > > IMHO, since the kselftest must run correctly on older kernel, > (and ftracetest does) Tom's kselftest patch should be merged > into linux-kselftest instead of tracing tree. > > Steve, what would you think? > No worries. As far as kselftest tree is concrned, I can apply these after rc1 comes out with Tom's patch. Or I can give Ack and Steve can take these through tracing tree. thanks, -- Shuah