From: Marcos Paulo de Souza <mpdesouza@suse.com>
To: Shuah Khan <skhan@linuxfoundation.org>,
Joe Lawrence <joe.lawrence@redhat.com>
Cc: Marcos Paulo de Souza <mpdesouza@suse.de>,
Shuah Khan <shuah@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
Josh Poimboeuf <jpoimboe@kernel.org>,
Jiri Kosina <jikos@kernel.org>, Petr Mladek <pmladek@suse.com>,
linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
live-patching@vger.kernel.org, Miroslav Benes <mbenes@suse.cz>
Subject: Re: [PATCH v3 3/3] selftests: livepatch: Test livepatching a heavily called syscall
Date: Wed, 20 Dec 2023 08:33:42 -0300 [thread overview]
Message-ID: <5a7cdb47541e357629437e0b482a1ca506c3b9f7.camel@suse.com> (raw)
In-Reply-To: <3a6b1886-c133-4893-8113-73f290b97390@linuxfoundation.org>
On Mon, 2023-12-18 at 13:47 -0700, Shuah Khan wrote:
> On 12/15/23 13:36, Joe Lawrence wrote:
> > On 12/11/23 16:53, Shuah Khan wrote:
> > > On 12/6/23 07:39, Miroslav Benes wrote:
> > > > Hi,
> > > >
> > > > On Tue, 5 Dec 2023, Shuah Khan wrote:
> > > >
> > > > > On 12/5/23 05:52, mpdesouza@suse.com wrote:
> > > > > > On Fri, 2023-12-01 at 16:38 +0000, Shuah Khan wrote:
> > > > >
> > > > > > 0003-selftests-livepatch-Test-livepatching-a-heavily-
> > > > > > call.patch has
> > > > > > style problems, please review.
> > > > > >
> > > > > > NOTE: If any of the errors are false positives, please
> > > > > > report
> > > > > > them to the maintainer, see CHECKPATCH in
> > > > > > MAINTAINERS.
> > > > > >
> > > > > > I couldn't find any mention about "missing module name". Is
> > > > > > your script
> > > > > > showing more warnings than these ones? Can you please share
> > > > > > your
> > > > > > output?
> > > > > >
> > > > > > I'll fix MAINTAINERS file but I'll wait until I understand
> > > > > > what's
> > > > > > missing in your checkpatch script to resend the patchset.
> > > > > >
> > > > >
> > > > > Looks like it is coming a script - still my question stands
> > > > > on
> > > > > whether or not you would need a module name for this module?
> > > >
> > > > I admit I am also clueless here. The module name is given in
> > > > Makefile. In
> > > > this case in test_modules/Makefile. I do not know of anything
> > > > else. There
> > > > is no MODULE_NAME macro. Could you elaborate, please?
> > > >
> > >
> > > I see that now.
> > >
> >
> > Hi Shuah,
> >
> > In the other replies to this thread, Marcos noted that he would add
> > some
> > text to the commit / documentation on running and building the
> > selftests
> > directly in the kernel tree (that would get my Ack) ... is there
> > anything else to be updated for a hopefully final v4 (for your
> > Ack)?
> >
>
>
> I am waiting for v4 with your comments are addressed. I can take
> this through kselftest tree.
Ok. I'm already preparing the v4. The plan is to send in the next few
days.
Thanks,
Marcos
>
> thanks,
> -- Shuah
>
next prev parent reply other threads:[~2023-12-20 11:33 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-31 21:10 [PATCH v3 0/3] livepatch: Move modules to selftests and add a new test Marcos Paulo de Souza
2023-10-31 21:10 ` [PATCH v3 1/3] kselftests: lib.mk: Add TEST_GEN_MODS_DIR variable Marcos Paulo de Souza
2023-10-31 21:10 ` [PATCH v3 2/3] livepatch: Move tests from lib/livepatch to selftests/livepatch Marcos Paulo de Souza
2023-12-01 15:27 ` Joe Lawrence
2023-12-06 15:05 ` Miroslav Benes
2023-12-07 15:20 ` Joe Lawrence
2023-12-07 19:19 ` mpdesouza
2023-12-11 21:56 ` Shuah Khan
2023-12-12 2:01 ` Marcos Paulo de Souza
2023-12-08 8:06 ` Miroslav Benes
2023-12-08 12:43 ` Petr Mladek
2023-10-31 21:10 ` [PATCH v3 3/3] selftests: livepatch: Test livepatching a heavily called syscall Marcos Paulo de Souza
2023-11-30 23:24 ` Shuah Khan
2023-12-01 13:13 ` Marcos Paulo de Souza
2023-12-01 16:38 ` Shuah Khan
2023-12-05 12:52 ` mpdesouza
2023-12-05 15:39 ` Shuah Khan
2023-12-06 14:39 ` Miroslav Benes
2023-12-11 21:53 ` Shuah Khan
2023-12-15 20:36 ` Joe Lawrence
2023-12-18 20:47 ` Shuah Khan
2023-12-20 11:33 ` Marcos Paulo de Souza [this message]
2023-11-30 13:42 ` [PATCH v3 0/3] livepatch: Move modules to selftests and add a new test Marcos Paulo de Souza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a7cdb47541e357629437e0b482a1ca506c3b9f7.camel@suse.com \
--to=mpdesouza@suse.com \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=corbet@lwn.net \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jpoimboe@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=mpdesouza@suse.de \
--cc=pmladek@suse.com \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox