Re: [V9fs-developer] [PATCH 1/8] fs/9p: Deletion of unnecessary checks before the function call "p9_client_clunk"

SF Markus Elfring
2015-01-06T14:34:38Z

>> jumping to label error from a failure in p9_client_fcreate (e.g. EPERM
>> or something perfectly valid) will, with your patch, call clunk with fid
>> == NULL and thus generate a stack trace, while it is a perfectly normal
>> code path that should only return to userspace with EPERM.
>
> Actually just seen that this precise example is fixed along with more
> similar code paths in subsequents (!) patchs of the set.

Do you refer to my update suggestions with a subject like "One function
call less in v9fs_…" here?

> It could actually be interesting to see if we could get all such
> paths "fixed".

Would you like to see any more specific source code clean-up?
Which kind of fine-tuning have you got in mind?

Regards,
Markus