Re: [PATCH 1/1] netfilter: Deletion of unnecessary checks before two function calls

Pablo Neira Ayuso
2014-11-20T12:14:12Z

On Thu, Nov 20, 2014 at 10:13:59AM +0900, Simon Horman wrote:
> On Thu, Nov 20, 2014 at 12:26:56AM +0200, Julian Anastasov wrote:
> >
> > Hello,
> >
> > On Tue, 18 Nov 2014, SF Markus Elfring wrote:
> >
> > > From: Markus Elfring <elfring@users.sourceforge.net>
> > > Date: Tue, 18 Nov 2014 20:37:05 +0100
> > >
> > > The functions free_percpu() and module_put() test whether their argument
> > > is NULL and then return immediately. Thus the test around the call is
> > > not needed.
> > >
> > > This issue was detected by using the Coccinelle software.
> > >
> > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> >
> > Pablo, the IPVS parts look ok to me,
> >
> > Acked-by: Julian Anastasov <ja@ssi.bg>
>
> Acked-by: Simon Horman <horms@verge.net.au>

Applied, thanks.