[PATCH] SRAM: Delete an unnecessary check before the function call "of_node_put"

SF Markus Elfring
2015-11-06T09:43:54Z

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 6 Nov 2015 10:36:49 +0100

The of_node_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/misc/sram.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/misc/sram.c b/drivers/misc/sram.c
index 736dae7..34287f7 100644
--- a/drivers/misc/sram.c
+++ b/drivers/misc/sram.c
@@ -326,9 +326,7 @@ static int sram_reserve_regions(struct sram_dev *sram, struct resource *res)
}

err_chunks:
- if (child)
- of_node_put(child);
-
+ of_node_put(child);
kfree(rblocks);

return ret;
--
2.6.2