Re: [PATCH v2] fs-fat: Less function calls in fat_fill_super() after error detection

OGAWA Hirofumi
2014-11-29T10:44:20Z

SF Markus Elfring <elfring@users.sourceforge.net> writes:

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 29 Nov 2014 07:37:34 +0100
>
> The iput() function was called in an inefficient way by the implementation
> of the fat_fill_super() function in case of an allocation failure.
> The corresponding source code was improved by deletion of two unnecessary
> null pointer checks and a few adjustments for jump labels.

iput() checks NULL of inode. What is wrong just remove NULL check,
instead of adding new jump labels?

Thanks.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>