From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1ABE033CE8A for ; Fri, 7 Nov 2025 18:58:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762541913; cv=none; b=hQEn+/FF0IbkiHshnikQDs4LL12T87ra2OkiVWDN38XzXfUau/MzzvUCZPY34OvjELKJhkx7c0O8mNA9eyY9Ny1wty3dlZW+ggPea0xdGkbdIu9wg5l+D5+ZFSlT0e3bc0pxIwLoxECZRS88ojF4aDPKQvkZVXpB+c28qQt78Mk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762541913; c=relaxed/simple; bh=RjrzCirQRAEDbjwBlo3vQ/iH4XgQ/gFqjek9EfoLwkI=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=fD3kaWW7Q1JeQCHGD5Ku2iIk9iXBnJ0UH47N/Rb42YMXJAUusRaX8cOCq+ljd1w97TcsR4fDx/oyfVoxKDeeQ8ZkR02ar8y7HdQUVu5vs24aXdFVOwcwZHEVNUyK/Q+2M2ffzPIoC68KFfK+LEfCgzeHwRI2LLxx9diMy0AJujQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PxkRGH2T; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PxkRGH2T" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-290aaff555eso10106595ad.2 for ; Fri, 07 Nov 2025 10:58:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1762541911; x=1763146711; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=RjrzCirQRAEDbjwBlo3vQ/iH4XgQ/gFqjek9EfoLwkI=; b=PxkRGH2TIiAF0PDEfx7e261KG4HHCHINVzILcYN2g3JsxpgBrE9iAKZtrwtiFKhs8H HLTeK2tGIABxPeo7KZaKvq0Qrmo4ppG0xcf637oop5SrT25Y6+4Od7pdC5j9NSoTgORg g7zFOtBbD1AMQoGuNubrEXs2QpxHTEZ4AoYGDXpH8Sv+6RNOphIkpgcrxameXZHtNwYD NbzRGs/aPSbBX54hmOxIL0i8m+j62Xbr6RkRA7KW7ly5RNcrBWxctS99M2JSPnOQZX8N ob9Ahigb7wOKIjvNAdjrkdsbw/VFRRysivR5X6L57z8/fu4SkaFL/2E/nZtPF8wrjW/G UunQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762541911; x=1763146711; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RjrzCirQRAEDbjwBlo3vQ/iH4XgQ/gFqjek9EfoLwkI=; b=v0c1wkuVFRv77dxGErOPr66Fr//MOUmvFH/KXa7KO2GUBl5/2AhQn2sRgdGBSCSZ7v ldnz49uqrXf4oRrNOa+B6d/ShUSPWm5IV52+b/dVDneyaQzNhOxNFeUbj0hcopksCmld T1FcwzswGUv9oAV1EZQTjM27UA34QyIOeeGZYPLdH3isM9EaeO2i2K4DOnnL+Zvtvxki TkBVgVZJeGrbAR7Ur3yZtiHIMavTqM1PV/4MYBqaJnX1TXVZSnOvpC1/mEFMAZ+cDWWN s9I2wcpl/EQQFYqDIB98IQLF3VhiDd41N+ZRtFyNEShXb8ACNGWAx3DZu0CrIo2DSiVU OX/g== X-Forwarded-Encrypted: i=1; AJvYcCXrywzizgYMa/maVAo1y/A6cnez7RGyNIQkHCHuErP9H7B+f0DsAwEpkMV9Tx146KTsg1o1wA7+FTTlgd8=@vger.kernel.org X-Gm-Message-State: AOJu0YwstIwDOfV0bdI4HEd1CfcQZxdZ+04AAZOpsHZED8xQu1LUYMxL gRxRZLmo1D0KP6cAjahyf8ALqypafNi4VA2zPyI96xtLO9KxK6YUxAY+ityYm0nA X-Gm-Gg: ASbGncs9dG31D7i732aBN2sizzYDtSahUBR4zsKkMh1DmGJ3oUdd9ytmisdT8eByRrP eJG5dlOM2udNzsTkIeMxrUntxOZYOeJVkNgRHVydojW88tLf+zhuc7LLN54wz7YjIW4u+KJq+8h KrzkUBwBjCrqOKh2V9q8KPP//NlzJkX3RfG4HL0Opvmr2OprEfNgsbeLj1YsTxZFN5tmqooLvm4 j18w6uceWrEnR7m1lUpnO0iqKZsJ1ZxUbEacsWGiXhAGn0j6ANs2R3mDOnEjNQksx9ZklhWOn6R BhhZ7/iAXovHu7q42iDpDgi4wG2ekVPzr39wnGjw9/F+gCKJSCnALL2HEzZeSDrMaa/sU5hXrde DkwoNx9uRu8Jbrq0JYIFTO4YMmylSCJIak6aAvXnsbig5yfSbDgeuoN+2z1cYa6t8Xp70m21O X-Google-Smtp-Source: AGHT+IGpMuuRbaDk+Z+7AaaKmSwq/CPtj/ja76biPbWaMcvP2DENiGEkr+xomRRcSSIxRfBq0JnZdg== X-Received: by 2002:a17:903:1745:b0:295:5945:2920 with SMTP id d9443c01a7336-297e56c9ea9mr1236415ad.34.1762541911527; Fri, 07 Nov 2025 10:58:31 -0800 (PST) Received: from [192.168.0.56] ([38.34.87.7]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29650c5e5bdsm66901325ad.39.2025.11.07.10.58.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Nov 2025 10:58:31 -0800 (PST) Message-ID: <5a8c765f8e2b4473d9833d468ea43ad8ea7e57b6.camel@gmail.com> Subject: Re: [PATCH v5 6/7] btf: Add lazy sorting validation for binary search From: Eduard Zingerman To: Alexei Starovoitov Cc: Donglin Peng , bot+bpf-ci@kernel.org, Alexei Starovoitov , Andrii Nakryiko , zhangxiaoqin@xiaomi.com, LKML , bpf , Alan Maguire , Song Liu , pengdonglin , Andrii Nakryiko , Daniel Borkmann , Martin KaFai Lau , Yonghong Song , Chris Mason , Ihor Solodrai Date: Fri, 07 Nov 2025 10:58:27 -0800 In-Reply-To: References: <20251106131956.1222864-7-dolinux.peng@gmail.com> <74d4c8e40e61dad369607ecd8b98f58a515479f0.camel@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2 (3.56.2-2.fc42) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Fri, 2025-11-07 at 10:54 -0800, Alexei Starovoitov wrote: [...] > > > > > @@ -610,7 +674,7 @@ s32 btf_find_by_name_kind(const struct > > > > > btf > > > > > *btf, const char *name, u8 kind) > > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 goto out; > > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } > > > > >=20 > > > > > -=C2=A0=C2=A0=C2=A0=C2=A0 if (btf->nr_sorted_types !=3D BTF_NEED_= SORT_CHECK) { > > > > > +=C2=A0=C2=A0=C2=A0=C2=A0 if (btf_check_sorted((struct btf *)btf)= ) { > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^ > > > >=20 > > > > The const cast here enables the concurrent writes discussed > > > > above. > > > > Is > > > > there a reason to mark the btf parameter as const if we're > > > > modifying it? > > >=20 > > > Hi team, is casting away const an acceptable approach for our > > > codebase? > >=20 > > Casting away const is undefined behaviour, e.g. see paragraph > > 6.7.3.6 > > N1570 ISO/IEC 9899:201x Programming languages =E2=80=94 C. > >=20 > > Both of the problems above can be avoided if kernel will do sorted > > check non-lazily. But Andrii and Alexei seem to like that property. >=20 > Ihor is going to move BTF manipulations into resolve_btfid. > Sorting of BTF should be in resolve_btfid as well. > This way the build process will guarantee that BTF is sorted > to the kernel liking. So the kernel doesn't even need to check > that BTF is sorted. This would be great. Does this imply that module BTFs are sorted too?