From: Shuah Khan <skhan@linuxfoundation.org>
To: Guillaume Tucker <guillaume.tucker@collabora.com>,
Nathan Chancellor <nathan@kernel.org>,
Shuah Khan <shuah@kernel.org>
Cc: Nick Desaulniers <ndesaulniers@google.com>,
Tom Rix <trix@redhat.com>, Mark Brown <broonie@kernel.org>,
kernel@collabora.com, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, llvm@lists.linux.dev,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] selftests: add missing ')' in lib.mk
Date: Fri, 3 Feb 2023 09:14:24 -0700 [thread overview]
Message-ID: <5aae3491-3d17-2880-90c9-864d45d7c455@linuxfoundation.org> (raw)
In-Reply-To: <6a7db0df-4f91-293a-35a9-2af77fa36dff@collabora.com>
On 2/3/23 08:40, Guillaume Tucker wrote:
> On 09/08/2022 18:36, Nathan Chancellor wrote:
>> On Tue, Aug 09, 2022 at 03:20:46PM +0200, Guillaume Tucker wrote:
>>> Add missing closing ')' in lib.mk in a call to $error(). This only
>>> affects LLVM / Clang builds.
>>>
>>> Fixes: 795285ef2425 ("selftests: Fix clang cross compilation")
>>> Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
>>
>> Reviewed-by: Nathan Chancellor <nathan@kernel.org>
>
> Ha, I see Mark just came up with the same fix many months later :)
> Shame this wasn't applied back then, for some reason...
>
It might have gotten lost in my Inbox (looking at the dates - must have
been while I was away on vacation). Sorry about that.
It is fixed now.
thanks,
-- Shuah
prev parent reply other threads:[~2023-02-03 16:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 13:20 [PATCH] selftests: add missing ')' in lib.mk Guillaume Tucker
2022-08-09 16:36 ` Nathan Chancellor
2023-02-03 15:40 ` Guillaume Tucker
2023-02-03 16:14 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5aae3491-3d17-2880-90c9-864d45d7c455@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=broonie@kernel.org \
--cc=guillaume.tucker@collabora.com \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=shuah@kernel.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox