From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f46.google.com (mail-io1-f46.google.com [209.85.166.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84513D517 for ; Thu, 2 Jan 2025 22:06:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735855615; cv=none; b=PY1CgVIUBNrqrYK4N0POG59KhIM9Yjw4vu6dSLDj2f4GO4mhKFenKhE4N174VTWcGIteAcZflW1ACFB8jTcqkP3AiISFQtFxYi/1Uj488/HteHAE9AUip5uewCzHK38ptfS5SaE3D33h2v3AkZW2Bk2qRmx1mNhR6a9oXw/K/SU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735855615; c=relaxed/simple; bh=ZETTRJwWortn7dIPcMDOHABFRqyP9QOwkgg6QV7/u7U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=k2OUXb7bQTUnbIFrqXGE1R8/baDJAowL+fqA2y42gEOxc1/TGbEa3LYzS5B3C9Q3tnQakyiDmUgnGEE4ogwwFjSxwOhI9n5mspr+9zH8C3GnIgmqh5gtuf/WckdSnPnhwMKDpQYSRUN058pIfPPZ8HLR7AMS83RFVwHxaAEkGzY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ZhIMga2j; arc=none smtp.client-ip=209.85.166.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ZhIMga2j" Received: by mail-io1-f46.google.com with SMTP id ca18e2360f4ac-844e7bc6d84so460335539f.0 for ; Thu, 02 Jan 2025 14:06:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1735855611; x=1736460411; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=dhrqI4fwHJQZxCWiS9FVGkBs6IaEV0Wmqj+W+ex1WNA=; b=ZhIMga2jJXC1OoSm8QMopR3BcuyXcYbrcUduqyO4Wa1meYhUUuh+ly2Aq6YWvqGJHZ E1mA1pwEP45pvt4G0EHDatncCPuahc1RFz8fgIWj5E9xgOy9gznUcx2UZ+pxWnH7Vexs uRsGkqYoOo9ZlqjIDSvIZNX0yyjWkz7akgi24= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735855611; x=1736460411; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dhrqI4fwHJQZxCWiS9FVGkBs6IaEV0Wmqj+W+ex1WNA=; b=LLnM+LwDF64NW1/86ZNEW+EvJ4xuOGT9ArCMvUMUDkLyr0B6g1/6BhNA9oJZcYSf56 p02F6ABOJ9+W4WfAsnhA+YsuIk1quwvyBzyCsu3x5G3I7whWfF6XfvKedhZMx7PmJjFM mCnXNuNNF/WMZt8v6jZOkWO6wbkboRiIGoqmreD7sqpVF10G8YGpz3M7rv7tyC+IX8ku K4gNrHN4O0yv3Ep4yHFbrX6B524qzrH/Iqt3V4PzteyEI2TjZFlK80xRKBGWiwiZY1Ce SEHhAsMeepECtSKQl6PtbCrg/RuzmGfFCLIaePxzJeIdM6fQ3se8H4c5cH8ELjnJYsVE dzfA== X-Forwarded-Encrypted: i=1; AJvYcCUiV8Q+Y31i+g19SXgbuxdP9y6xRAe8oll8215QTv/Pru5+sH8OPjg4bHqcid+YiQRIjw8KjD/NG0wYPKo=@vger.kernel.org X-Gm-Message-State: AOJu0YyZqYsqm16JP21diw9kQIHs3VA5rXViewL2XZWVmCGhu9QbbzyF PAWrfkPa4bHEvs+Ct6rLTZ9Grf1QURMfEEpLch73ONcwteiTkxhLz8diqGWq0IU= X-Gm-Gg: ASbGncvXrOOKFmzTlT85D9MtAWxyWfmoyDEMtaAkjtkWz9l5QUcfjFu3gfIprsQBPhL y3EPknmyDX7w1wBn6vUt3p0nCtqJWGkiPBJtmZfnBKvv45h8hsZthBMUSdlQawjUWsZJsQtSr0b rPsrseC/TvDV/Vs0OwB2QiEB91R5cocG92tXpnmAshd/r4SNLLibVPoSq7ZWEwK/j8WWvLjw2wp glVN51WRcG5nMILxhYqK1qfJOrorHN15lNE+R4UALHLspCdu5fU5MnwygwaX4YNAYp+ X-Google-Smtp-Source: AGHT+IEacw6THuLUSoeW9Do2UARQl/AgEK5APcT21cHRcY94QxycgSp/pBgaQX2s/8U4C9TiD15VtA== X-Received: by 2002:a5e:dc48:0:b0:83a:943d:a280 with SMTP id ca18e2360f4ac-849885adfbemr3389117939f.1.1735855611565; Thu, 02 Jan 2025 14:06:51 -0800 (PST) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id ca18e2360f4ac-8498d810f00sm679636439f.28.2025.01.02.14.06.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jan 2025 14:06:51 -0800 (PST) Message-ID: <5ad65964-dcf7-47d2-8e5f-bf82066e55f4@linuxfoundation.org> Date: Thu, 2 Jan 2025 15:06:50 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] usbip: Fix seqnum sign extension issue in vhci_tx_urb To: Xiong Nandi , Valentina Manea , Shuah Khan , Hongren Zheng , Greg Kroah-Hartman Cc: "open list:USB OVER IP DRIVER" , open list , Shuah Khan References: <20241231161539.20192-1-xndchn@gmail.com> <20241231161539.20192-2-xndchn@gmail.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <20241231161539.20192-2-xndchn@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/31/24 09:15, Xiong Nandi wrote: > The atomic_inc_return function returns an int, while priv->seqnum is an > unsigned long. So we must cast the result to u32 to prevent potential > sign extension and size mismatch issues. > How did you find the problem? > Signed-off-by: Xiong Nandi > --- > drivers/usb/usbip/vhci_hcd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c > index b03e5021c25b..f3f260e01791 100644 > --- a/drivers/usb/usbip/vhci_hcd.c > +++ b/drivers/usb/usbip/vhci_hcd.c > @@ -675,7 +675,7 @@ static void vhci_tx_urb(struct urb *urb, struct vhci_device *vdev) > > spin_lock_irqsave(&vdev->priv_lock, flags); > > - priv->seqnum = atomic_inc_return(&vhci_hcd->seqnum); > + priv->seqnum = (u32)atomic_inc_return(&vhci_hcd->seqnum); Why does it make sense to cast it to u32? > if (priv->seqnum == 0xffff) > dev_info(&urb->dev->dev, "seqnum max\n"); thanks, -- Shuah