From: Markus Elfring <Markus.Elfring@web.de>
To: Johan Hovold <johan@kernel.org>, linux-sound@vger.kernel.org
Cc: Johan Hovold <johan+linaro@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Peter Rosin <peda@axentia.se>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Takashi Iwai <tiwai@suse.com>
Subject: Re: [1/2] ASoC: codecs: wcd938x: fix mux error handling
Date: Tue, 15 Apr 2025 15:57:03 +0200 [thread overview]
Message-ID: <5af56acb-7758-4641-8acc-b81e7c8de709@web.de> (raw)
In-Reply-To: <Z_5i6YUSGivzaOCb@hovoldconsulting.com>
>> May the error code assignment statement be omitted here together with extra curly brackets
>> (as such a case is demonstrated in a subsequent if branch)?
>
> I considered that, but I prefer using a temporary variable as it is more readable.
Would your coding style preferences be inconsistent here?
Regards,
Markus
next prev parent reply other threads:[~2025-04-15 13:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-15 7:41 [PATCH 0/2] ASoC: codecs: wcd938x: fix mux error handling Johan Hovold
2025-04-15 7:41 ` [PATCH 1/2] " Johan Hovold
2025-04-15 10:00 ` Markus Elfring
2025-04-15 13:45 ` Johan Hovold
2025-04-15 13:57 ` Markus Elfring [this message]
2025-04-15 7:41 ` [PATCH 2/2] ASoC: codecs: wcd938x: drop unnecessary mux flag assignment Johan Hovold
2025-04-25 18:57 ` [PATCH 0/2] ASoC: codecs: wcd938x: fix mux error handling Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5af56acb-7758-4641-8acc-b81e7c8de709@web.de \
--to=markus.elfring@web.de \
--cc=broonie@kernel.org \
--cc=johan+linaro@kernel.org \
--cc=johan@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=peda@axentia.se \
--cc=perex@perex.cz \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox