Re: [PATCH 6/8] arm64: dts: Add Arm Morello System Development Platform support

Vincenzo Frascino
2024-12-19T17:31:04Z

On 14/12/2024 10:14, Krzysztof Kozlowski wrote:
> On 13/12/2024 17:32, Vincenzo Frascino wrote:
>> The Morello architecture is an experimental extension to Armv8.2-A,
>> which extends the AArch64 state with the principles proposed in
>> version 7 of the Capability Hardware Enhanced RISC Instructions
>> (CHERI) ISA.
>>
>> Introduce Arm Morello System Development Platform support.
>>
>> Cc: Sudeep Holla <sudeep.holla@arm.com>
>> Cc: Rob Herring <robh@kernel.org>
>> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
>> ---
>> arch/arm64/boot/dts/arm/Makefile | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/boot/dts/arm/Makefile b/arch/arm64/boot/dts/arm/Makefile
>> index d908e96d7ddc..0a821808692e 100644
>> --- a/arch/arm64/boot/dts/arm/Makefile
>> +++ b/arch/arm64/boot/dts/arm/Makefile
>> @@ -7,3 +7,4 @@ dtb-$(CONFIG_ARCH_VEXPRESS) += rtsm_ve-aemv8a.dtb
>> dtb-$(CONFIG_ARCH_VEXPRESS) += vexpress-v2f-1xv7-ca53x2.dtb
>> dtb-$(CONFIG_ARCH_VEXPRESS) += fvp-base-revc.dtb
>> dtb-$(CONFIG_ARCH_VEXPRESS) += corstone1000-fvp.dtb corstone1000-mps3.dtb
>> +dtb-$(CONFIG_ARCH_MORELLO) += morello-soc.dtb
>
> No, you organize patches in insane way. Makefile is never, never
> separate entry.
>
> Look how all existing submissions were done.
>
> Squash the patches.
>

Generally in v1 I tend to make evident things on which I want comments to make
sure they are not missed.

Here and in the previous patch I wanted to know if ARCH_MORELLO could live as a
separate entity.

Now that you replied, it will be squashed where it belongs in v2.

> You also did not CC several people and at least arm kernel list. Use
> standard tools for development instead of inventing your own process.
>
>
> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC (and consider --no-git-fallback argument, so you will
> not CC people just because they made one commit years ago). It might
> happen, that command when run on an older kernel, gives you outdated
> entries. Therefore please be sure you base your patches on recent Linux
> kernel.
>
> Tools like b4 or scripts/get_maintainer.pl provide you proper list of
> people, so fix your workflow. Tools might also fail if you work on some
> ancient tree (don't, instead use mainline) or work on fork of kernel
> (don't, instead use mainline). Just use b4 and everything should be
> fine, although remember about `b4 prep --auto-to-cc` if you added new
> patches to the patchset.
>
>
>
>
> Best regards,
> Krzysztof

--
Regards,
Vincenzo