From: Oleksandr Natalenko <oleksandr@natalenko.name>
To: Paolo Valente <paolo.valente@linaro.org>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block <linux-block@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
linus.walleij@linaro.org, bfq-iosched@googlegroups.com,
Chris Evich <cevich@redhat.com>,
Patrick Dung <patdung100@gmail.com>,
Thorsten Schubert <tschubert@bafh.org>
Subject: Re: [PATCH BUGFIX] block, bfq: deschedule empty bfq_queues not referred by any process
Date: Thu, 14 Nov 2019 09:53:25 +0100 [thread overview]
Message-ID: <5b0b07fc8e50a1beac215230ca84d955@natalenko.name> (raw)
In-Reply-To: <69B451DE-B04B-4E0E-9464-826C4A7619AD@linaro.org>
Hi.
On 13.11.2019 18:42, Paolo Valente wrote:
>> Il giorno 13 nov 2019, alle ore 16:01, Oleksandr Natalenko
>> <oleksandr@natalenko.name> ha scritto:
> Ok, you may have given me enough information, thank you very much.
>
> Could you please apply the attached (compressed) patch on top of my
> offending patch? For review purposes, here is the simple change:
>
> --- a/block/bfq-iosched.c
> +++ b/block/bfq-iosched.c
> @@ -2728,7 +2728,8 @@ void bfq_release_process_ref(struct bfq_data
> *bfqd, struct bfq_queue *bfqq)
> * freed when dequeued from service. But this is assumed to
> * never happen.
> */
> - if (bfq_bfqq_busy(bfqq) && RB_EMPTY_ROOT(&bfqq->sort_list))
> + if (bfq_bfqq_busy(bfqq) && RB_EMPTY_ROOT(&bfqq->sort_list) &&
> + bfqq != bfqd->in_service_queue)
> bfq_del_bfqq_busy(bfqd, bfqq, false);
>
> bfq_put_queue(bfqq);
The issue is not reproducible for me after applying this patch.
Thank you.
--
Oleksandr Natalenko (post-factum)
next prev parent reply other threads:[~2019-11-14 8:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 7:48 [PATCH BUGFIX] block, bfq: deschedule empty bfq_queues not referred by any process Paolo Valente
2019-11-12 15:23 ` Jens Axboe
2019-11-12 17:49 ` Paolo Valente
2019-11-13 12:57 ` Oleksandr Natalenko
2019-11-13 13:52 ` Paolo Valente
2019-11-13 14:25 ` Oleksandr Natalenko
2019-11-13 15:01 ` Oleksandr Natalenko
2019-11-13 17:42 ` Paolo Valente
2019-11-13 22:46 ` Jens Axboe
2019-11-14 9:22 ` Paolo Valente
2019-11-14 8:53 ` Oleksandr Natalenko [this message]
2019-11-14 9:23 ` Paolo Valente
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b0b07fc8e50a1beac215230ca84d955@natalenko.name \
--to=oleksandr@natalenko.name \
--cc=axboe@kernel.dk \
--cc=bfq-iosched@googlegroups.com \
--cc=cevich@redhat.com \
--cc=linus.walleij@linaro.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paolo.valente@linaro.org \
--cc=patdung100@gmail.com \
--cc=tschubert@bafh.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox