Re: [PATCH RESEND v2 02/17] KVM: X86: Change parameter for fast_page_fault tracepoint

Paolo Bonzini
2020-01-08T17:46:08Z

On 21/12/19 02:49, Peter Xu wrote:
> It would be clearer to dump the return value to know easily on whether
> did we go through the fast path for handling current page fault.
> Remove the old two last parameters because after all the old/new sptes
> were dumped in the same line.
>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> arch/x86/kvm/mmutrace.h | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/arch/x86/kvm/mmutrace.h b/arch/x86/kvm/mmutrace.h
> index 7ca8831c7d1a..09bdc5c91650 100644
> --- a/arch/x86/kvm/mmutrace.h
> +++ b/arch/x86/kvm/mmutrace.h
> @@ -244,9 +244,6 @@ TRACE_EVENT(
> __entry->access)
> );
>
> -#define __spte_satisfied(__spte) \
> - (__entry->retry && is_writable_pte(__entry->__spte))
> -
> TRACE_EVENT(
> fast_page_fault,
> TP_PROTO(struct kvm_vcpu *vcpu, gva_t gva, u32 error_code,
> @@ -274,12 +271,10 @@ TRACE_EVENT(
> ),
>
> TP_printk("vcpu %d gva %lx error_code %s sptep %p old %#llx"
> - " new %llx spurious %d fixed %d", __entry->vcpu_id,
> + " new %llx ret %d", __entry->vcpu_id,
> __entry->gva, __print_flags(__entry->error_code, "|",
> kvm_mmu_trace_pferr_flags), __entry->sptep,
> - __entry->old_spte, __entry->new_spte,
> - __spte_satisfied(old_spte), __spte_satisfied(new_spte)
> - )
> + __entry->old_spte, __entry->new_spte, __entry->retry)
> );
>
> TRACE_EVENT(
>

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>