* net: ax25: %x specifier misuse in kernel?
@ 2019-04-19 2:01 PlusOneSecond
2019-04-19 3:02 ` Eric Dumazet
0 siblings, 1 reply; 2+ messages in thread
From: PlusOneSecond @ 2019-04-19 2:01 UTC (permalink / raw)
To: linux-kernel
In ax25_info_show of af_ax25.c:1891, linux-5.1.
The pointer ax25 is cast to long type to print out.
Why it prints the a pointer 'ax25' use %8.8lx rather than %p?
If it really want to print the value of ax25, it should use %px.
Also, I scan the kernel code and notice that most of the pointers cast to long or unsigned long type to print out are marked with __iomem.
Is it a misuse of %x?
Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: net: ax25: %x specifier misuse in kernel?
2019-04-19 2:01 net: ax25: %x specifier misuse in kernel? PlusOneSecond
@ 2019-04-19 3:02 ` Eric Dumazet
0 siblings, 0 replies; 2+ messages in thread
From: Eric Dumazet @ 2019-04-19 3:02 UTC (permalink / raw)
To: PlusOneSecond, linux-kernel
On 04/18/2019 07:01 PM, PlusOneSecond wrote:
> In ax25_info_show of af_ax25.c:1891, linux-5.1.
> The pointer ax25 is cast to long type to print out.
>
> Why it prints the a pointer 'ax25' use %8.8lx rather than %p?
> If it really want to print the value of ax25, it should use %px.
I guess nobody cared enough abut this security issue.
Please send a patch, thanks.
>
> Also, I scan the kernel code and notice that most of the pointers cast to long or unsigned long type to print out are marked with __iomem.
> Is it a misuse of %x?
>
>
> Thanks.
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-19 3:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-19 2:01 net: ax25: %x specifier misuse in kernel? PlusOneSecond
2019-04-19 3:02 ` Eric Dumazet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox