Re: [PATCH v1 4/4] platform/x86: int3472: Use str_high_low()

["Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1238 bytes --]

On Wed, 21 Aug 2024, Andy Shevchenko wrote:

> Use str_high_low() rather than open coding.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/platform/x86/intel/int3472/discrete.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/intel/int3472/discrete.c b/drivers/platform/x86/intel/int3472/discrete.c
> index 96a9673a0165..b5f6f71bb1dd 100644
> --- a/drivers/platform/x86/intel/int3472/discrete.c
> +++ b/drivers/platform/x86/intel/int3472/discrete.c
> @@ -11,6 +11,7 @@
>  #include <linux/module.h>
>  #include <linux/overflow.h>
>  #include <linux/platform_device.h>
> +#include <linux/string_choices.h>
>  #include <linux/uuid.h>
>  
>  #include "common.h"
> @@ -230,7 +231,7 @@ static int skl_int3472_handle_gpio_resources(struct acpi_resource *ares,
>  
>  	dev_dbg(int3472->dev, "%s %s pin %d active-%s\n", func,
>  		agpio->resource_source.string_ptr, agpio->pin_table[0],
> -		(polarity == GPIO_ACTIVE_HIGH) ? "high" : "low");
> +		str_high_low(polarity == GPIO_ACTIVE_HIGH));
>  
>  	switch (type) {
>  	case INT3472_GPIO_TYPE_RESET:
> 

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

-- 
 i.