Re: [RFC PATCH] resource: Fix CXL node not populated issue

Andy Shevchenko
2024-12-03T22:07:56Z

On Tue, Dec 03, 2024 at 11:56:35AM -0800, Gregory Price wrote:
> On Tue, Dec 3, 2024, 6:09 AM Andy Shevchenko <
> andriy.shevchenko@linux.intel.com> wrote:
> > On Tue, Dec 03, 2024 at 02:26:52PM +0800, Huang, Ying wrote:
> > > Raghavendra K T <raghavendra.kt@amd.com> writes:

...

> > > > git bisect had led to below commit
> > > > Fixes: b4afe4183ec7 ("resource: fix region_intersects() vs
> > add_memory_driver_managed()")
> > >
> > > This breaks you case, sorry about that. But this also fixed a real bug
> > > too. So, it's not appropriate just to revert it blindly.
> >
> > Linus was clear about this recently. Even if it fixes a bug, regression is
> > still regression
>
> In my experience, region intersection issues often stem from bad CEDT
> entries.

Yeah, sometimes fixes may reveal the hidden issues.

> Have you dumped the ACPI tables on your system and validated the content?

I believe this is the Q to the original reporter.

> It would be a shame to revert a patch because the ACPI tables were wrong.

I agree with you and as I said in my reply "fixes are better than reverts".
I.o.w. I'm on the same page with Linus on this.

--
With Best Regards,
Andy Shevchenko