Re: [RFC PATCH] resource: Fix CXL node not populated issue

Andy Shevchenko
2024-12-03T13:41:37Z

On Tue, Dec 03, 2024 at 02:26:52PM +0800, Huang, Ying wrote:
> Raghavendra K T <raghavendra.kt@amd.com> writes:

...

> > git bisect had led to below commit
> > Fixes: b4afe4183ec7 ("resource: fix region_intersects() vs add_memory_driver_managed()")
>
> This breaks you case, sorry about that. But this also fixed a real bug
> too. So, it's not appropriate just to revert it blindly.

Linus was clear about this recently. Even if it fixes a bug, regression is
still regression and might (*) lead to a revert.
https://lwn.net/Articles/990599/

(*) in general fixes are better than reverts, but depends on the timing in
the release cycle the revert may be the only option.

--
With Best Regards,
Andy Shevchenko