Re: [RFC PATCH v2 0/3] platform/x86: acer-wmi: Add fan control support

[Armin Wolf <W_Armin@gmx.de>]

Am 23.08.25 um 03:27 schrieb Fa-Iz Faadhillah Ibrahim:

>
> On 8/22/25 7:02 PM, Armin Wolf wrote:
>> Am 15.08.25 um 08:17 schrieb Fa-Iz Faadhillah Ibrahim:
>>
>>>> > This experimental patch series aims to add fan control support to 
>>>> the > acer-wmi driver. The patches are compile-tested only and need 
>>>> to be > tested on real hardware to verify that they actually work. 
>>>> > > I CCed two users who requested support for this feature. I 
>>>> would be > very happy if both of you could test those patches and 
>>>> report back. > > I am ready to help you both with compiling a 
>>>> custom linux kernel for > testing this series.
>>>> Any updates from the two people with Acer hardware?
>>>>
>>>> Thanks,
>>>> Armin Wolf
>>>
>>> Hello, I've tried your patch on my Predator Helios Neo 16 (PHN16-72)
>>> using quirks from PH16-72 and it looks like fan control works just 
>>> fine.
>>> On other note, can you please add PHN16-72 to the quirk table?
>>> if you need anything to test please do notify.
>>>
>>> Thanks,
>>> Fa-Iz Faadhillah Ibrahim
>>>
>> Hi,
>>
>> sorry for taking a bit long to respond, i am currently on vacation. 
>> Nice to know that the experimental patches work :).
>> Can you send me the output of "acpidump" on your machine?
> Hello,
>
> Sorry for disturbing your vacation, hope you're having a great time :).
> Output of "acpidump" attached below.
>
> P.S. Sorry for the messed up formatting before, first time here so I'm 
> still learning how this works, hopefully it'll be okay now.
>
> Thanks,
> Fa-Iz Faadhillah Ibrahim

Thanks.

Would it be OK for you if i send the non-RFC patches once i am back home (around 15.09.)? The reason for this
is that i made some improvements to the RFC patches, but those improved patches are only stored on my develop
machine at home.

Thanks,
Armin Wolf

>>
>> Thanks,
>> Armin Wolf
>>
>>>>
>>>> > Changes since v2: > - remove duplicate include and replace 
>>>> hwmon_pwm_mode with > hwmon_pwm_enable in second patch > > Armin 
>>>> Wolf (3): > platform/x86: acer-wmi: Fix setting of fan behavior > 
>>>> platform/x86: acer-wmi: Add fan control support > platform/x86: 
>>>> acer-wmi: Enable fan control for PH16-72 and PT14-51 > > 
>>>> drivers/platform/x86/acer-wmi.c | 298 
>>>> +++++++++++++++++++++++++++++--- > 1 file changed, 273 
>>>> insertions(+), 25 deletions(-) > > -- > 2.39.5 > >
>>>> ------------------------------------------------------------------------ 
>>>>
>>>
>>>