From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26C61C54EE9 for ; Mon, 19 Sep 2022 08:52:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230045AbiISIwt (ORCPT ); Mon, 19 Sep 2022 04:52:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230168AbiISIw0 (ORCPT ); Mon, 19 Sep 2022 04:52:26 -0400 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 106A422BFD for ; Mon, 19 Sep 2022 01:52:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663577530; x=1695113530; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=soUQOddqp60l+A0SvBrHsI8rwpW1H/6Q8f4MbqONHts=; b=SoZzs+736uPee0XWD4l9aAjuXnKTrl5pgTLdYytmTmiZ9PjbKQF1cVkx LzhJoB8SuHNZdymSWHFZnL3JQwgjRWVEDAPO9HmXJ+IkFbMmpmWErl1m6 kus2oyi+SQrHw8gZF/Ky+2HasEx0+gSZrjc4OWXeF5KMS125airA2p7l7 FDMhjfzyOkrGTWD7DDvBHJ+Cq33sImh1gtwrOW89Vw2Z2Os0DAJ/Dm04g GYIvTKSAffqdwTXfNPNLLKgTwPlJ0e9GGoiJcdmTs93Dz1F/bJgzWjC80 uqEpm+lRZSZtIyNyYSb0wwMhJMJvA0/q7s5tLFiWiRX58NEh0Bj8FjdmE g==; X-IronPort-AV: E=McAfee;i="6500,9779,10474"; a="298073445" X-IronPort-AV: E=Sophos;i="5.93,327,1654585200"; d="scan'208";a="298073445" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Sep 2022 01:52:09 -0700 X-IronPort-AV: E=Sophos;i="5.93,327,1654585200"; d="scan'208";a="680761406" Received: from ilick-mobl1.ger.corp.intel.com (HELO [10.252.59.91]) ([10.252.59.91]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Sep 2022 01:52:03 -0700 Message-ID: <5b9040e8-fe19-2438-0072-74b2f0d914e3@linux.intel.com> Date: Mon, 19 Sep 2022 10:39:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.11.0 Subject: Re: [PATCH] soundwire: cadence: Write to correct address for each FIFO chunk Content-Language: en-US To: Richard Fitzgerald , vkoul@kernel.org, yung-chuan.liao@linux.intel.com, sanyog.r.kale@intel.com Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com References: <20220917123517.229153-1-rf@opensource.cirrus.com> From: Pierre-Louis Bossart In-Reply-To: <20220917123517.229153-1-rf@opensource.cirrus.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/17/22 14:35, Richard Fitzgerald wrote: > _cdns_xfer_msg() must add the fragment offset to msg->addr to get the > base target address of each FIFO chunk. Otherwise every chunk will > be written to the first 32 register addresses. > > Signed-off-by: Richard Fitzgerald > --- > drivers/soundwire/cadence_master.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soundwire/cadence_master.c b/drivers/soundwire/cadence_master.c > index 3ef472049980..ca241bbeadd9 100644 > --- a/drivers/soundwire/cadence_master.c > +++ b/drivers/soundwire/cadence_master.c > @@ -569,7 +569,7 @@ _cdns_xfer_msg(struct sdw_cdns *cdns, struct sdw_msg *msg, int cmd, > } > > base = CDNS_MCP_CMD_BASE; > - addr = msg->addr; > + addr = msg->addr + offset; LGTM, probably means that sending a large command broken in several pieces never worked. D'oh. Reviewed-by: Pierre-Louis Bossart Thanks Richard! > > for (i = 0; i < count; i++) { > data = FIELD_PREP(CDNS_MCP_CMD_DEV_ADDR, msg->dev_num);