Re: [PATCH v2 5/5] Documentation: admin-guide: pm: Add documentation for die_id

["Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1534 bytes --]

On Mon, 28 Apr 2025, Srinivas Pandruvada wrote:

> Add documentation to describe die_id attribute.
> 
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
> v2:
> Change "attributes" to "attribute"
> 
>  .../admin-guide/pm/intel_uncore_frequency_scaling.rst        | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/admin-guide/pm/intel_uncore_frequency_scaling.rst b/Documentation/admin-guide/pm/intel_uncore_frequency_scaling.rst
> index 84608dad84bd..d7ffda6a8095 100644
> --- a/Documentation/admin-guide/pm/intel_uncore_frequency_scaling.rst
> +++ b/Documentation/admin-guide/pm/intel_uncore_frequency_scaling.rst
> @@ -91,6 +91,11 @@ Attributes in each directory:
>  ``domain_id``
>  	This attribute is used to get the power domain id of this instance.
>  
> +``die_id``
> +	This attribute is used to get the Linux die id of this instance.
> +	This attribute is only present for domains with core agents and
> +        when the CPUID leaf 0x1f presents die ID.
> +
>  ``fabric_cluster_id``
>  	This attribute is used to get the fabric cluster id of this instance.
>  
> 

For patches #2-#5,

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

It would have been nice to use cleanup.h in #3 but there's no good 
alternative for no_free_ptr() that doesn't have __must_check (IIRC, 
somebody proposed a solution to this relatively recently but I don't see 
that in linux/cleanup.h currently so lets forget that for now).

-- 
 i.