From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Alex Bee <knaerzche@gmail.com>, Kalle Valo <kvalo@kernel.org>,
linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev,
brcm80211-dev-list.pdl@broadcom.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] wifi: brcmfmac: of: Support interrupts-extended
Date: Sun, 23 Jun 2024 20:10:47 +0200 [thread overview]
Message-ID: <5baaffe4-058d-462f-abce-ecaeeeff9647@broadcom.com> (raw)
In-Reply-To: <20240622215416.659208-1-knaerzche@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 825 bytes --]
On 6/22/2024 11:54 PM, Alex Bee wrote:
> The currently existing of_property_present check for interrupts does not
> cover all ways interrupts can be defined in a device tree, e.g.
> "interrupts-extended".
>
> In order to support all current and future ways that can be done, drop that
> check and call of_irq_parse_one to figure out if an interrupt is defined
> and irq_create_of_mapping for the actual mapping and let it be handled by
> the interrupt subsystem.
Thanks for the rework. Looks good.
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> Signed-off-by: Alex Bee <knaerzche@gmail.com>
> ---
> Link to v1:
> https://lore.kernel.org/all/20240621225558.280462-1-knaerzche@gmail.com/
>
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4219 bytes --]
next prev parent reply other threads:[~2024-06-23 18:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-22 21:54 [PATCH v2] wifi: brcmfmac: of: Support interrupts-extended Alex Bee
2024-06-23 18:10 ` Arend van Spriel [this message]
2024-06-26 17:51 ` Kalle Valo
2025-01-05 15:49 ` Luca Weiss
2025-01-05 20:36 ` Alex Bee
2025-01-06 16:51 ` Luca Weiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5baaffe4-058d-462f-abce-ecaeeeff9647@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211@lists.linux.dev \
--cc=knaerzche@gmail.com \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox