From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f181.google.com (mail-dy1-f181.google.com [74.125.82.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DB77318BAC for ; Thu, 19 Feb 2026 20:39:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771533544; cv=none; b=hLzvVG/wpq+kC9Po/WD8cknfzGw6PTAE1gwgdjF8cCJUFJLEkh0L5/N60FMMUxiisfPVZsRuhqsJeUuEerOBqyy9n/YGW1fQ+FFqa5zUmMXejMKReHvYWOclL5gNe9JJ+6bHgYAFX46NpM+VVFQb3VNqK1xZesslkym0jhOWsGU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771533544; c=relaxed/simple; bh=+8WdIeayvQwTa1EO0ctLm8O+l21nYzdUf7o4bczyCAQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DH4MBt2gLmb7muO4b0Jg/ef9/T2oP6kQ8I5r3yyx5WX7MPl27s25Ff/Ax6R02T43x8C7tVk+bQIJafmS9NR4W0JYTqHPzO9dU5gxZJNM2h8wW+FLdKaMY/3Oy+nS19iSIAq7hrVD03lAJggHmrRzN+n/L6aMS3Cdqh0myMPx1Xk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=V5smHirx; arc=none smtp.client-ip=74.125.82.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="V5smHirx" Received: by mail-dy1-f181.google.com with SMTP id 5a478bee46e88-2baa098ffc6so1285107eec.0 for ; Thu, 19 Feb 2026 12:39:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1771533542; x=1772138342; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SI/A7iNXCicM0eX7PESju9pA0T4gNBVRW7g2h/AnymA=; b=V5smHirx/j0NvvcbaYqORRLcRESItsM/vtuSDTRrrSoczn0CRNE6ZTCY6evAwGfnAE iiJRCptNclwdWCN6pHCo6VWu8LhC9sDERKGhghvt+LeDGclNmjmgeAgS036Pq1cUJUMK dIzbGmWx+LDUrvkxgTjsPR7gbcVabsaJl8OpWKTsYUYNtAq03hwew6bjyjlGlI2UkxyX tTlitqIHHv3oHyZYcSQKSRSDT7aSt7jIuLkcJCU/WnwJngzL4hN3DP1WDXeRwMY4c90s rBqyQR/SzjQZC4/7ND+6AseYNIynUaV3kTtzGu5eJJyLSp2XKowA8I3n1u/AFk/vcAeb zw0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771533542; x=1772138342; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SI/A7iNXCicM0eX7PESju9pA0T4gNBVRW7g2h/AnymA=; b=qJ7XkyhioYcJioLBMO9nCp+MU/nF07H1BfDKsTXO9jmvMe2eqpaF/XikCoU2h2X77Y jns1B/fAz63UPsA7jJmyrkGOZI1v8B+9VFq3pAlU56ksZ/xbtJM5eDDwmhz6/74F1jIQ 7wCGyMEz1vQ5OsKT2zZ9eKx4AvCY2CXBGA2UwgrWN7kl5BICL0Ws6X6B73fNeydkXtZU bb6JsL78za32jK11CT9W4bzFqPKKf683k6vYxc16ZPN6Zwhy6KO2UFx0r15IA93Wm+ue cnvfzI3P4+PeJ8LuqQvMjH0meuKSstLGFuaxOGj017JB53aZmQMf/0Ihck/O0X6PshR+ F8SA== X-Gm-Message-State: AOJu0YwNvNBz4YTvI2UWq5ubBU1Le+IAimYA+nTwcK+IrY+Mzjgy+84y T6GcY7FyACAK6jlGJ8BWAKXHDFvZWbz1Ix412YlxdqHadodFZdbYPw5Hvzj+tkc3xg== X-Gm-Gg: AZuq6aKesurvFXWITu1NtldgmP5ofTrQ3t9iVEjeD3kiaonegNWiadgnaQOVGrifaq6 aiw1JzjLeKwE6oxWSiRc6j3EnixAd8phxF4MMKkw3cGP7RohH6J4H2D0sOQ7WwuauekbSAWTS06 RzwR6VX5cu84L4zQqDRZb4CVqT3XnlzUB7v+e5eZnkeKwGH/AyacfC+gsTchnEhUpTEjqC/NRQc B9BrfhNveHakCEG5Xv2hLvyuCM0WtaYCeFZCuOWzX9VhAsoBWfiqdBwoVZtdQISjUjudWELnv7Q aFQH2GLdW0yZFw+SSRA80X6KeQF5NL99C+w4s3gF3JudU92NVo8RxFoVeAit2XcVZBFFh9xk29p LZM6ALYj7N/wUslM9Gni2DlU2tYFfjbEO8SVIKYX/4z/PK8IxPM0bMwrs/vbjXX5eY5GvMRNI7T Q56M+YS0Gd7WdvJu5sRexjGbl7Z0ia5/7T4H/BCHdRWI58OVrS8Ms/YPpoyDBrYGkgoK0yvucfM W/AUpEJDXGqquT4Yie+H/Y4ww== X-Received: by 2002:a05:7300:cb15:b0:2b0:48f7:837d with SMTP id 5a478bee46e88-2baba03cffcmr6411860eec.11.1771533541615; Thu, 19 Feb 2026 12:39:01 -0800 (PST) Received: from ?IPV6:2a00:79e0:2e7c:8:748f:1ebc:e491:46c0? ([2a00:79e0:2e7c:8:748f:1ebc:e491:46c0]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2bacb658544sm24546429eec.17.2026.02.19.12.39.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Feb 2026 12:39:01 -0800 (PST) Message-ID: <5bcc02b3-2785-4fc4-ab58-2dd94ea7b00a@google.com> Date: Thu, 19 Feb 2026 12:38:59 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 5/6] power: supply: max77759: add charger driver To: =?UTF-8?Q?Andr=C3=A9_Draszik?= , Sebastian Reichel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lee Jones , Greg Kroah-Hartman , Badhri Jagan Sridharan , Heikki Krogerus , Peter Griffin , Tudor Ambarus , Alim Akhtar , Mark Brown , Matti Vaittinen , Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, RD Babiera , Kyle Tso References: <20260218-max77759-charger-v7-0-e8d907ce69c5@google.com> <20260218-max77759-charger-v7-5-e8d907ce69c5@google.com> Content-Language: en-US From: Amit Sunil Dhamne In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Andre', On 2/19/26 7:52 AM, André Draszik wrote: > Hi Amit, > > I was trying out your series and noticed a few things that I didn't before: > > On Wed, 2026-02-18 at 21:59 +0000, Amit Sunil Dhamne via B4 Relay wrote: > > [...] > >> diff --git a/drivers/power/supply/max77759_charger.c b/drivers/power/supply/max77759_charger.c >> new file mode 100644 >> index 0000000000000000000000000000000000000000..035f16822d85de94c7707ce11c49345c714cd559 >> --- /dev/null >> +++ b/drivers/power/supply/max77759_charger.c > [...] > >> + dev_err(chg->dev, "Invalid mode transition from %d to %d", >> + chg->mode, mode); > All your format strings are missing the final \n throughout this patch. Sorry will fix. I think this is because of my muscle memory from writing `tcpm_log` (which doesn't require an escape character). > > [...] > >> +static int max77759_charger_probe(struct platform_device *pdev) >> +{ >> + struct regulator_config chgin_otg_reg_cfg; >> + struct power_supply_config psy_cfg; >> + struct device *dev = &pdev->dev; >> + struct max77759_charger *chg; >> + int ret; >> + >> + device_set_of_node_from_dev(dev, dev->parent); >> + chg = devm_kzalloc(dev, sizeof(*chg), GFP_KERNEL); >> + if (!chg) >> + return -ENOMEM; >> + >> + platform_set_drvdata(pdev, chg); >> + chg->dev = dev; >> + chg->regmap = dev_get_regmap(dev->parent, "charger"); >> + if (!chg->regmap) >> + return dev_err_probe(dev, -ENODEV, "Missing regmap"); >> + >> + ret = devm_mutex_init(dev, &chg->lock); >> + if (ret) >> + return dev_err_probe(dev, ret, "Failed to initialize lock"); >> + >> + ret = devm_mutex_init(dev, &chg->retry_lock); >> + if (ret) >> + return dev_err_probe(dev, ret, >> +      "Failed to initialize retry_lock"); >> + >> + psy_cfg.fwnode = dev_fwnode(dev); >> + psy_cfg.drv_data = chg; >> + chg->psy = devm_power_supply_register(dev, &max77759_charger_desc, >> +       &psy_cfg); >> + if (IS_ERR(chg->psy)) >> + return dev_err_probe(dev, -EPROBE_DEFER, >> +      "Failed to register psy, ret=%ld", >> +      PTR_ERR(chg->psy)); > Why are you returning -EPROBE_DEFER here instead of the original error? This > is quite unusual. Will fix. The original thought was that the power_supply_check_supplies() (run as part of power_supply_register()) wasn't deferring probe if it didn't find its provider device but I was mistaken. Regards, Amit > > Cheers, > Andre'