From: Shuah Khan <skhan@linuxfoundation.org>
To: Vincent Donnefort <vdonnefort@google.com>,
rostedt@goodmis.org, mhiramat@kernel.org,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Cc: mathieu.desnoyers@efficios.com, kernel-team@android.com,
rdunlap@infradead.org, rppt@kernel.org, david@redhat.com,
Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org,
Muhammad Usama Anjum <usama.anjum@collabora.com>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v22 5/5] ring-buffer/selftest: Add ring-buffer mapping test
Date: Fri, 3 May 2024 13:12:56 -0600 [thread overview]
Message-ID: <5bdb08a2-0740-4ea0-be24-a948332d60ac@linuxfoundation.org> (raw)
In-Reply-To: <20240430111354.637356-6-vdonnefort@google.com>
On 4/30/24 05:13, Vincent Donnefort wrote:
> This test maps a ring-buffer and validate the meta-page after reset and
> after emitting few events.
>
Changelog needs to be imperative - refer to the following:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html
Update the change log and describe what the test does and include
test output.
If the test requires root privileges - make sure add a check to skip
when a normal use runs the test.
The rest looks good.
thanks,
-- Shuah
next prev parent reply other threads:[~2024-05-03 19:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 11:13 [PATCH v22 0/5] Introducing trace buffer mapping by user-space Vincent Donnefort
2024-04-30 11:13 ` [PATCH v22 1/5] ring-buffer: Allocate sub-buffers with __GFP_COMP Vincent Donnefort
2024-05-02 13:18 ` David Hildenbrand
2024-04-30 11:13 ` [PATCH v22 2/5] ring-buffer: Introducing ring-buffer mapping functions Vincent Donnefort
2024-05-02 13:30 ` David Hildenbrand
2024-05-02 13:38 ` Vincent Donnefort
2024-05-02 13:46 ` Steven Rostedt
2024-05-08 2:34 ` Steven Rostedt
2024-05-09 11:05 ` Vincent Donnefort
2024-05-10 9:15 ` David Hildenbrand
2024-05-10 10:57 ` Vincent Donnefort
2024-05-10 9:19 ` David Hildenbrand
2024-05-10 11:03 ` Vincent Donnefort
2024-05-10 18:42 ` Steven Rostedt
2024-04-30 11:13 ` [PATCH v22 3/5] tracing: Allow user-space mapping of the ring-buffer Vincent Donnefort
2024-04-30 11:13 ` [PATCH v22 4/5] Documentation: tracing: Add ring-buffer mapping Vincent Donnefort
2024-04-30 11:13 ` [PATCH v22 5/5] ring-buffer/selftest: Add ring-buffer mapping test Vincent Donnefort
2024-05-03 19:12 ` Shuah Khan [this message]
2024-05-07 23:35 ` Steven Rostedt
2024-05-10 11:04 ` Vincent Donnefort
2024-05-10 18:44 ` Steven Rostedt
2024-05-10 18:50 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5bdb08a2-0740-4ea0-be24-a948332d60ac@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=david@redhat.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=rppt@kernel.org \
--cc=shuah@kernel.org \
--cc=usama.anjum@collabora.com \
--cc=vdonnefort@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox