From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29F0C2D73B4 for ; Thu, 13 Nov 2025 09:09:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763024994; cv=none; b=TOhKXntBC4wTRLzYCI6OmSTIZLVKcKpkD80mCPC026xzU/n5nn1XoyU2tkI9YPsU54FGSNrNXsxtEniTGkLej35wuY5jZHkvlEgiLpnRmLbW2sFANRBe34PqGgYhM3wnKUT475ddI/n4pjONYGjnBoVsoYaj6EnbA2a2v0RKun8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763024994; c=relaxed/simple; bh=rHmd0rMUHyefZtIXeMVesUbxq18R88JCSA0oFW1Fm0M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bXsZ6eISDkqZ8Vo5CVOIPjn2ToFKwRqyS5p0qG9Dbn85vqRWcy2uxb0IpjtBn5o/Xp38VxDrZxZTL2r0uy/Nntoi1m1YVL4l6y8q1mg91dJtvrllOsCTpzYKlzqVHk2KuVdnx7ipa5+NCYN/FOSHPEQm47spUzfYDohLgu4XhaI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=uj6/Pi6b; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="uj6/Pi6b" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D5EDC113D0; Thu, 13 Nov 2025 09:09:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763024993; bh=rHmd0rMUHyefZtIXeMVesUbxq18R88JCSA0oFW1Fm0M=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=uj6/Pi6bfNWw9ZykppZ3qDAZRUlr46B7/demige9vo17lWrcE75ESNOuLgJFYiQjk 8u5/IVA5HgmEyMUG83YUQqs8bmhFarX/1SdJofCeyX0Q9i9oA2in1+hNhxxTYal3iJ 4DUfJTloVfkqDlg/TPjiWY6my6JLWQ7kUqouZXhXcRJgL4W+YTsqP+Ul0us4XWLP2y 2u+zaaLg1iULPBIsBLLCfohBG5bBrdeYMUgA1KgAeWLNktelgyw/NkMK+16ELR/OnI WX+m/WjJd86on3z4csb4zbIydeIC7sQI2P4EmrV17qM5k+XyzsU+vbwhDw1hi00DdL jdKgUbGWYif6w== Message-ID: <5bdd8b10-171e-4171-a1f2-43c029dfd8e4@kernel.org> Date: Thu, 13 Nov 2025 10:09:44 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] fix gpu/drm/nouveau: fix return type in nouveau_dmem_migrate_to_ram() To: Balbir Singh , linux-kernel@vger.kernel.org, linux-mm@kvack.org, dri-devel@lists.freedesktop.org Cc: kernel test robot , Andrew Morton , Zi Yan , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Oscar Salvador , Lorenzo Stoakes , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lyude Paul , Danilo Krummrich , David Airlie , Simona Vetter , Ralph Campbell , =?UTF-8?Q?Mika_Penttil=C3=A4?= , Matthew Brost , Francois Dugast References: <20251113051322.1753532-1-balbirs@nvidia.com> From: "David Hildenbrand (Red Hat)" Content-Language: en-US In-Reply-To: <20251113051322.1753532-1-balbirs@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 13.11.25 06:13, Balbir Singh wrote: > ret of type vm_fault_t is reused to capture the return value of > nouveau_dmem_copy_folio(), which returns an int. Use a new copy_ret > to fix the issue. The issue is not new, prior to this the function > called was called nouveau_dmem_copy_one() and ret was used to capture > it's value. > > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202511121922.oP20Lzb8-lkp@intel.com/ It's a sparse warning, is there any runtime effect? > > Cc: Andrew Morton > Cc: David Hildenbrand > Cc: Zi Yan > Cc: Joshua Hahn > Cc: Rakie Kim > Cc: Byungchul Park > Cc: Gregory Price > Cc: Ying Huang > Cc: Alistair Popple > Cc: Oscar Salvador > Cc: Lorenzo Stoakes > Cc: Baolin Wang > Cc: "Liam R. Howlett" > Cc: Nico Pache > Cc: Ryan Roberts > Cc: Dev Jain > Cc: Barry Song > Cc: Lyude Paul > Cc: Danilo Krummrich > Cc: David Airlie > Cc: Simona Vetter > Cc: Ralph Campbell > Cc: Mika Penttilä > Cc: Matthew Brost > Cc: Francois Dugast > Fixes: ? Or is does this just fix a sparse warning and nothing "real" we could run into and cause problems? -- Cheers David