From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 297E5C35640 for ; Fri, 21 Feb 2020 07:46:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 071DE20801 for ; Fri, 21 Feb 2020 07:46:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728786AbgBUHqr (ORCPT ); Fri, 21 Feb 2020 02:46:47 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:54898 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726940AbgBUHqh (ORCPT ); Fri, 21 Feb 2020 02:46:37 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: eballetbo) with ESMTPSA id 8BF432904EA Subject: Re: [PATCH v8 1/6] drm/mediatek: Use regmap for register access To: Randy Dunlap , robh+dt@kernel.org, mark.rutland@arm.com, ck.hu@mediatek.com, p.zabel@pengutronix.de, airlied@linux.ie, mturquette@baylibre.com, sboyd@kernel.org, ulrich.hecht+renesas@gmail.com, laurent.pinchart@ideasonboard.com Cc: Mauro Carvalho Chehab , dri-devel@lists.freedesktop.org, Weiyi Lu , Seiya Wang , linux-clk@vger.kernel.org, Collabora Kernel ML , mtk01761 , Allison Randal , Thomas Gleixner , wens@csie.org, Kate Stewart , Greg Kroah-Hartman , Houlong Wei , Matthias Brugger , linux-media@vger.kernel.org, devicetree@vger.kernel.org, sean.wang@mediatek.com, frank-w@public-files.de, Minghsiu Tsai , Andrew-CT Chen , linux-mediatek@lists.infradead.org, hsinyi@chromium.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org, Richard Fontana , linux-kernel@vger.kernel.org, matthias.bgg@kernel.org, Daniel Vetter References: <20200220172147.919996-1-enric.balletbo@collabora.com> <20200220172147.919996-2-enric.balletbo@collabora.com> <0b2046b9-90de-c894-7502-993b5df12e7a@infradead.org> From: Enric Balletbo i Serra Message-ID: <5c19af7a-170b-2cd1-da98-e4125504eb34@collabora.com> Date: Fri, 21 Feb 2020 08:46:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <0b2046b9-90de-c894-7502-993b5df12e7a@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Randy, On 21/2/20 0:48, Randy Dunlap wrote: > On 2/20/20 9:21 AM, Enric Balletbo i Serra wrote: >> From: Matthias Brugger >> >> The mmsys memory space is shared between the drm and the >> clk driver. Use regmap to access it. >> >> Signed-off-by: Matthias Brugger >> Reviewed-by: Philipp Zabel >> Reviewed-by: CK Hu >> Signed-off-by: Enric Balletbo i Serra >> --- >> >> Changes in v8: None >> Changes in v7: >> - Add R-by from CK >> >> drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 4 +- >> drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 50 +++++++++++-------------- >> drivers/gpu/drm/mediatek/mtk_drm_ddp.h | 4 +- >> drivers/gpu/drm/mediatek/mtk_drm_drv.c | 13 ++----- >> drivers/gpu/drm/mediatek/mtk_drm_drv.h | 2 +- >> 5 files changed, 30 insertions(+), 43 deletions(-) > > Hi. Just a quick question: > > Do you need to select REGMAP or one of its derivatives to make sure > that the proper interfaces are available for this driver? > Right, I will fix this in next version. > thanks. >