From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757906AbdELOZp (ORCPT ); Fri, 12 May 2017 10:25:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:50312 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757416AbdELOZn (ORCPT ); Fri, 12 May 2017 10:25:43 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E2C72399C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dinguyen@kernel.org Subject: Re: [PATCH] socfpga_a10: reset CPU1 in socfpga_cpu_kill() To: yanjiang.jin@windriver.com, hiraku.toyooka.gu@hitachi.com, linux@arm.linux.org.uk References: <20170510051304.131042-1-yanjiang.jin@windriver.com> <20170510051304.131042-2-yanjiang.jin@windriver.com> Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, jinyanjiang@gmail.com From: Dinh Nguyen Message-ID: <5c3ad20d-5d22-3164-e678-5122efed4d74@kernel.org> Date: Fri, 12 May 2017 09:25:32 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170510051304.131042-2-yanjiang.jin@windriver.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/10/2017 12:13 AM, yanjiang.jin@windriver.com wrote: > From: Yanjiang Jin > > Kexec's second kernel would hang if CPU1 isn't reset. > Can you please be a bit more descriptive on the commit log? Is it because when kexec starts, the SMP on the kexec's kernel try to run on CPU1? > Signed-off-by: Yanjiang Jin > --- > arch/arm/mach-socfpga/platsmp.c | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/mach-socfpga/platsmp.c b/arch/arm/mach-socfpga/platsmp.c > index 0ee7677..db3940e 100644 > --- a/arch/arm/mach-socfpga/platsmp.c > +++ b/arch/arm/mach-socfpga/platsmp.c > @@ -117,6 +117,16 @@ static int socfpga_cpu_kill(unsigned int cpu) > { > return 1; > } > + > +static int socfpga_a10_cpu_kill(unsigned int cpu) > +{ > + /* This will put CPU #1 into reset. */ > + if (socfpga_cpu1start_addr) Do you need to check for socfpga_cpu1start_addr? Dinh