From: "André Lopes" <andre.neo.net@gmail.com>
To: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Are the cast necessary in function "kfree"?
Date: Wed, 20 May 2009 11:30:21 +0100 [thread overview]
Message-ID: <5c43c2d40905200330p5b14be2ey567bc493374e09b3@mail.gmail.com> (raw)
Hi. This is my first post :-)
I was reading this doc (/linux-2.6/Documentation/scsi/ChangeLog.lpfc),
when I found this phrase: "Replace some kfree((void*)ptr) with
kfree(ptr)."
After that I created a script to detect this situation, in Linux
source code. The results were:
arch/mips/alchemy/common/dbdma.c:408: kfree((const void *)desc_base);
arch/mips/alchemy/common/dbdma.c:834: kfree((void *)ctp->chan_desc_base);
arch/s390/include/asm/idals.h:110: kfree((void *)(unsigned
long) ccw->cda);
arch/powerpc/mm/pgtable_32.c:90: kfree((void *)pgd);
drivers/ide/ide-acpi.c:369: kfree((void *)obj_loc);
drivers/net/vxge/vxge-config.c:4962: kfree((void *)p);
drivers/net/vxge/vxge-config.h:1970: kfree((void *)tmp);
drivers/net/wan/pc300_tty.c:699: kfree((void *)buf);
drivers/net/wireless/zd1211rw/zd_chip.c:149: kfree((void *)a16);
drivers/net/lance.c:367: kfree((void*)lp->rx_buffs);
drivers/net/lance.c:742: kfree((void*)lp->rx_buffs);
drivers/net/ucc_geth.c:1890: kfree((void
*)ugeth->tx_bd_ring_offset[i]);
drivers/net/ucc_geth.c:1920: kfree((void
*)ugeth->rx_bd_ring_offset[i]);
drivers/s390/char/vmur.c:188: kfree((void *)(addr_t) ptr->cda);
drivers/block/paride/bpck6.c:227: kfree((void *)(pi->private));
drivers/infiniband/hw/cxgb3/iwch_provider.c:449: kfree((void *)
(unsigned long) mhp->kva);
drivers/staging/epl/EplTarget.h:99:#define EPL_FREE(ptr)
kfree((void *)ptr)
drivers/video/console/fbcon.c:960: kfree((void *) softback_buf);
drivers/video/console/fbcon.c:3428: kfree((void *)softback_buf);
drivers/video/au1100fb.c:614: kfree((void*)fbdev);
drivers/pci/rom.c:259: kfree((void*)(unsigned long)res->start);
drivers/isdn/hisax/config.c:1272: kfree((void *) cards[cardnr].cs);
drivers/isdn/hisax/fsm.c:47: kfree((void *) fsm->jumpmatrix);
drivers/isdn/mISDN/fsm.c:54: kfree((void *) fsm->jumpmatrix);
net/sched/ematch.c:401: kfree((void *) em->data);
net/sched/em_meta.c:577: kfree((void *) v->val);
sound/oss/sh_dac_audio.c:325: kfree((void *)data_buffer);
sound/pci/ice1712/ak4xxx.c:158: kfree((void*)ak->private_value[0]);
sound/pci/emu10k1/emufx.c:1724: kfree((void __force *)icode->gpr_map);
sound/pci/emu10k1/emufx.c:2345: kfree((void __force *)icode->gpr_map);
The prototype for kfree() is:
#include<linux/slab.h>
void kfree(const void *objp)
These casts are not necessary...I think so. If it's yes, can we apply
patch's to clean-up this?
Thanks.
next reply other threads:[~2009-05-20 10:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-20 10:30 André Lopes [this message]
2009-05-20 10:38 ` Are the cast necessary in function "kfree"? Christian Bornträger
2009-05-20 11:16 ` Paul Mundt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c43c2d40905200330p5b14be2ey567bc493374e09b3@mail.gmail.com \
--to=andre.neo.net@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).