From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70407342CB0 for ; Thu, 30 Apr 2026 16:48:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777567719; cv=none; b=NLxNxFjqgPWFX6+C5cQcOZ/M4+Hpo79R+BiKLKCKo8J4WXoP9ceK+cPpSUMso+mwA1n/Ot4ETmEeH49X5DgVcH8hmxyExZslKJGfO7gdL3zY9zawxCXlbm8o4dA8cTAdWf2CdjRaCW0tEyndHAg1cFeYh/x2M8AVZ6whCnTRDcU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777567719; c=relaxed/simple; bh=iyHbIkFdXPqVIKb5+L3th6PStWzVqWAUPryssGRqqWo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=anAPR1cuTCMpAsVB/2SRz8Uc3tPkLpyFFUNQ7HgRjJatN86c53Dxfx86e/9WByTh+7TVX85YdOEoq5rCKze8poE8sjJWXHcRiz7XoiHkHPuGfi35fpv+9A+JLlh0+Qv8UmsdQz3anjJWw7LkYBprqOoobRq7772+AfsQjxpUGz0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZIFTqGWt; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VTcrCQhF; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZIFTqGWt"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VTcrCQhF" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63UFON5e2099698 for ; Thu, 30 Apr 2026 16:48:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= SV7o9l8CrqKI3O2AoXkSm6ZCuba3HAZ7LYr0cPU1ZLw=; b=ZIFTqGWtrPS7GYxw DtQ+Q2j/lx1w7j5e8vt9Y3cXUiEzXkQpK/JIJirhMTfYX1gaMpft1DL7Gu+WexdD /3al3xWvIU8I/cp1gZ4sMx9IiehupzxCSAe2W/W/KSn28mFfytoJF44uglxGDDUj tqjswAjT74hwz4AoDoFG2Pa9d4SEnxziHbH4HtYMYLQKycwJyeYDDP5QWJ+GOMnv plYIyBRagjkiHbN6GIakI95OjF5S0geQdaSTKViSD6xy/IWGRqqjtxp4ThYP3mvN hmpQwQMq64hbogG/s1HaafP/+F3LYe4LjYDOL/GifdjllIEMk6p/zE1Zffo5D5w6 nbxlkQ== Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4duyr433x7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 30 Apr 2026 16:48:37 +0000 (GMT) Received: by mail-vs1-f72.google.com with SMTP id ada2fe7eead31-605a884731dso113365137.1 for ; Thu, 30 Apr 2026 09:48:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777567716; x=1778172516; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SV7o9l8CrqKI3O2AoXkSm6ZCuba3HAZ7LYr0cPU1ZLw=; b=VTcrCQhF1EAzGQz6wBEdYW97cF+Or5trT8myfA+Dm4dBtRdYpvG1xIgL+03B8BgdHT N9NYNCfTh6mp8rrhlneKC3J44fKlnX/jYqnbRyWxZUcHXpf7wBhogI7Z9eIddpr+mknN AxVfJ+v3rP3PglHEnYnse+wu3ndWw7SZgW2WMI/wIr54EZF//JMUZHs2jLvlLPtvCaUM 751fs6MLpcgtEh2PGrXLY1vDdiv6D3B4liZNTIl0ShW3a7mLCZ7RjG5PA1VSwGi/n9jB kTJwdmg84BeKqhKOAzNMkDdf0SDVQrd6G4wxyUAgi/TVoYZDnv5m47AzC5o2Xyh4ul2v OJDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777567716; x=1778172516; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SV7o9l8CrqKI3O2AoXkSm6ZCuba3HAZ7LYr0cPU1ZLw=; b=YupmAul9puxhl1xXeEn9qVVB69w9NDygSsDAw7LCSfXrEQbTxGw84Xj9ZuA/NmvRnd I2uXiv9J22HKia1o06d5zyyAG+CqOt7rDwUparZducG1Kc68WV8FTAT6MAwqQgzzdeeX F7ZodAgNw/aEb982DvOTayWt1xzIUKx2igiKNrPW4+CZqmXqfGYfI6tdGjOcCIVATw0R YIs4NsNxJrl7/8RzT9xFAUEaQUmX2WJPu0u+oCoPv7dJJFuf72//7orxdX1WiktN2wTx oyfkjiorQNu7poBiKXtDBcWEKJOkrxip4zup6yvEmx4fjxbU+z7Fu+ONp3E14FScCBsm oBZg== X-Forwarded-Encrypted: i=1; AFNElJ/0ZpMqJ1ZxqlznGKjzuc+8UAUCCosCYvUqCcyCdAf38l4kdcDh+5uIMPQVEpxcpA2Se9EhrJAHr1JA9Tg=@vger.kernel.org X-Gm-Message-State: AOJu0YxgzIYnQNZFHm4fccj7GbrGiMlf0Jmdcd+QUVeWp68YLfJ/WGwt PtRUmXufmnhOXOhxeJ6q60tNrXeLu5IRcztaLjNWPY/NGohX7xdBQ4oC0z4YEEND6E0o8HdZhm+ jQJpbR1Ucb9HA8KdjrF9XzJE+5Ekb5Kx2iEnTwqxgbxc0ZqsKfVe2tMxI8qlN10gKaHI= X-Gm-Gg: AeBDieuGZG85Ia6TC/KBUOjwNXdJPzyo5If1BWYF0+SaJ8nlgq6ZlhJQVthj0w8kQ7o 6OwR2N01NomqZmKLYEl13HtnQS72uY1PwqfsaO+NsgxiNxDuvv2DDvw6cMwaojO+OLD7kQtND1y FdAk4zNF0eIFF1EQb4TRbCKaWM3wAn9t679+WDOse/A9Bi3wMJq6MVyo43+rQN1g/fvgT2QYH8c tnU6kcvrfxm+TrVkjw50ZIqGvtTMjqPiBbEmzOIF4maXQT/a6ZIkT4v8lOme0LawtK2JB2VpEJi pc7eFCFG6nD6gJTzJi5k95+0Cw9e7aXD6coBdG0mIhbbLFFwnCWT3kl0MKm6NFNSBx/zfGzcQ7Z 2FGuLw9+cunS5CePKbfvIz5x1MO4dDtVqzfVb4CIQ/gHzjJ1NLxaBNVByR9cjFMslRMhwNrvUgX erXuVQaWSvgOBpZQ== X-Received: by 2002:a05:6102:67c:b0:602:7589:6536 with SMTP id ada2fe7eead31-62ad2e44437mr760330137.2.1777567716293; Thu, 30 Apr 2026 09:48:36 -0700 (PDT) X-Received: by 2002:a05:6102:67c:b0:602:7589:6536 with SMTP id ada2fe7eead31-62ad2e44437mr760325137.2.1777567715784; Thu, 30 Apr 2026 09:48:35 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bbe6a64d919sm18279566b.23.2026.04.30.09.48.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Apr 2026 09:48:35 -0700 (PDT) Message-ID: <5c838838-00e5-45f2-9515-edbdcddf50ec@oss.qualcomm.com> Date: Thu, 30 Apr 2026 18:48:33 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Support for Lenovo IdeaCentre Mini X (Purwa) To: Mostafa Saleh , andersson@kernel.org, konradybcio@kernel.org Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, maz@kernel.org References: <20260429141815.827157-1-smostafa@google.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260429141815.827157-1-smostafa@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=bJcm5v+Z c=1 sm=1 tr=0 ts=69f387e5 cx=c_pps a=DUEm7b3gzWu7BqY5nP7+9g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=yZY3LKPz1QgPfZ98hF0A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=-aSRE8QhW-JAV6biHavz:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDMwMDE3MiBTYWx0ZWRfX8/C7a3wjVt76 2Rz76CnmbrmN11SM1NXRAmIDm66y2Bz4Hj+QsB9wQcNvhvVba8+8niQUKW//6/p0tJoFBJ53ZF3 a+372B9acw1dQABTvunwe5hv2H4X1mYRPmjy5WEWb6mdyk6qQhOL/0sRxRPMWdSmRzWKPS7iYuq mZhzDXDltpZ0Dc1ibwYgHit5KqXSCn88aGcKNjx3uG5mZSSyTtKkfIuTpReAIQ6wWHeK5XLkb1Y eq0rt39dCAABjwuLyQM7bGno/LjAU4ywYqKKAAYvjWO8V6pCethvvBp2c39fEB6mwSLqXoACPEb /qtyNdWxTXmfMHaDYg/vh8f1bdswTrdpjEygpHPsrjzkUVtMBa677L0h/f1aRj4/WrE8DnR3pJi m4zovoCA3Hc176YFrsfsmMxuVHnWLMtkO3iNlwhHWSlY6/XZ3UJLOx5QB0UPe4LSEu9DGT07LWL +lXu59EsH0CSs7rPqRg== X-Proofpoint-GUID: 9r0WFQ1fXLKVG3FwNE4ZB4UBJm_fDmf- X-Proofpoint-ORIG-GUID: 9r0WFQ1fXLKVG3FwNE4ZB4UBJm_fDmf- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-30_04,2026-04-30_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0 clxscore=1015 suspectscore=0 adultscore=0 lowpriorityscore=0 impostorscore=0 phishscore=0 malwarescore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604300172 On 4/29/26 4:18 PM, Mostafa Saleh wrote: > Hi, > > I see that recently the support for “Lenovo IdeaCentre Mini X” was > added [1] > However, unfortunately that doesn’t work for my device, the board > resets once I try to boot the kernel from UEFI. > > I believe that’s because it is another variant, as I have been using > my device tree for some time[2] which is hacked based on the crd > device tree with some trial and error. With that I can boot with > PCI/NVME/Ethernet and USB (there are also some other errors in the > log related PMIC), this device tree is based on purwa.dtsi unlike > the upstream one which use hamoa.dtsi. > > Are there any plans to support the Purwa based variant? I am happy to > help with testing, but I can’t confidently send patches as my device > tree is based on trial and error rather than a data sheet. Hello, could you try diff --git a/arch/arm64/boot/dts/qcom/hamoa-lenovo-ideacentre-mini-01q8x10.dts b/arch/arm64/boot/dts/qcom/hamoa-lenovo-ideacentre-mini-01q8x10.dts index bfb7cea56df9..845f303c3836 100644 --- a/arch/arm64/boot/dts/qcom/hamoa-lenovo-ideacentre-mini-01q8x10.dts +++ b/arch/arm64/boot/dts/qcom/hamoa-lenovo-ideacentre-mini-01q8x10.dts @@ -8,7 +8,7 @@ #include #include -#include "hamoa.dtsi" +#include "purwa.dtsi" #include "hamoa-pmics.dtsi" / { for starters? Konrad