From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F37B01D5151 for ; Mon, 9 Feb 2026 12:32:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770640368; cv=none; b=sXn4hfnNZKrBm18PpGAkhfetMsypJuA0VQz2UW30p5g2d8wTYd3LOYgjkDYJeO5jQxIC/T+7wfiK/WJcQ+TLyd/evmeP48l7/Y9e0g0S75sFcBujcOD1bS0e549L8UH/NGMdbiKlOgINWSTb6pammEpCbflT5gSlOYQ6okcszgg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770640368; c=relaxed/simple; bh=9UGfwTK4y1fO2Dxay5nCxgZmQpRbsjMPeMLLw5M6ijM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=o+0+WreQSVSueXTPlXGeI+xK1hJqa5tE+zEfYfkz2+R8uviZaEdGxqu5RGG3wxClPWyoJw37hweuz3c5qFWomAu9e3rcVsnvwhdlh4TZjg5ETN89/qYNNFtDHmBBS20nWUrtoh/fe96Pfzm8/1i7LTBZO9EmXdqDBopv9AMgfGM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Vmvo7uqX; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Vmvo7uqX" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-4362d4050c1so2858619f8f.2 for ; Mon, 09 Feb 2026 04:32:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770640366; x=1771245166; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Jd+15egrLJWlYZ9cb8Lr+KvIvhkInyayF1h1fbgSSCY=; b=Vmvo7uqXDQjcw8KtJc6rlimjG4Vm9EYUUhIzqW9Uud15yucOKTAp9kRysaP0VtRLew /DzvClrvkkCdX7XFK0FyWyHFVinrXuKh/lGnW98ooXDsXa0hMhTYHrb4Bmdq8/g/zs8j o/QvA9/cWBdwqh/Zn4dnXmUGfK3rCWDE16dHmdyosNGVrajO+kibL7fdN4RgtDm6CZNe 8oj7f4jOCifJfJiucbN622Zo0plgA0BRVlVF+gXuVarMxfu1zYBkaacBvYYTwjmLH4hA yPBTMdrNzlEhk+GeBQIk6wAmixOjNyUU6e6wdhHBkqdttSA8X+6GhD5DOT8acxClFIC2 BKww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770640366; x=1771245166; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Jd+15egrLJWlYZ9cb8Lr+KvIvhkInyayF1h1fbgSSCY=; b=G9e0nTIyBOYT7sbj1XP1ZVeJElANYH0nzea8sOARNqiemIvvCA+A40q8DLHIOTQW8Y RuQEcxiVt+3IYH0Vz9oF4yV5QIa1PkmNsh0pQIoEGH2/3mMJJ3PkOUvLsuvRGElyrfgv rgj0MFwsxd335KLIDFktWsXB0WpQ0tqvngVlp5UZRSVnYdugm83v3G9pBweuqvfjAPl9 iH6Qvz0HKHF318duSzZC9pzG6GlC7KZ/78IRfkxLhwKf+FFK2lj4SGhELTs7ZQa6hhT0 mgG+GeiKp92jtC0r7UvVeEc3G4YqCDA3RrJk84T7GZjnys8R7s1yvWX/LYjmlmAg211f hokw== X-Forwarded-Encrypted: i=1; AJvYcCW0hihIEBXw+sPvwvm7BPVTPLabdpATQ7qDv07VRqRZFgNmnbE6wkgMTUNnFN875f+fFDh4O3uzCfFp2pk=@vger.kernel.org X-Gm-Message-State: AOJu0YzH5ocW/mCQxtQMILud5bLTTqIsSPmhLx/0nQAzIl58UCkd8fPO KCvH6AiU6vUz7+Ly4XA2t32la59uqMzW92MeFENSC8rlv2I6O9rgzU6a X-Gm-Gg: AZuq6aLxfOB1d+MvEKrNayBhfdG3TTp0X7wUFFRIblzhvLIFmR15ZrMP8EYjM0Kajmz L1EoQHF1K0jfVp3e2UqQ1wXGADypvxvrwxecL/FaFa06GRzHItNnpbWY+NAuGkAwsntMVYNkrgd a99+bmv288lQvw9IJVjWagCJrv9q2DZZWNcrkuJebc7zO2h2cxYSR4NOz0McvQZaHRHvWB+07Pb l5+1Y5Dojs8GXMcxMC8QBXZEgTxg77PXaou2bBlAuYWtBr+9qgcTAH5jDoaY/2mJk7a1XGtX3SQ H5BdVxgVLtcyhxeIJHk62b3Nqwp9EIWMvnpwu9lYISfDniWBpHQ+RyY8iagBkr17yrycjPQHDTF RJL/J8DsBhdU09Ietnsuutob6CFpvLXCy5U8mLqmbMufTaaikuvM3ponyV8Z+eZlXYA512WrysH U1/psurQNdGmWm59Uei3N66kJ8zBaHFelFi3g= X-Received: by 2002:a5d:588b:0:b0:435:abbb:fa77 with SMTP id ffacd0b85a97d-43629341e02mr17567690f8f.20.1770640366299; Mon, 09 Feb 2026 04:32:46 -0800 (PST) Received: from [192.168.0.7] ([86.124.200.187]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4376d3a32basm9541684f8f.14.2026.02.09.04.32.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Feb 2026 04:32:46 -0800 (PST) Message-ID: <5c97b29f-c26d-4209-a74d-763d813576ef@gmail.com> Date: Mon, 9 Feb 2026 14:32:45 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 1/2] staging: axis-fifo: use u32 for fifo depth flags To: Gustavo Piaz da Silva , gregkh@linuxfoundation.org, dan.carpenter@linaro.org Cc: gshahrouzi@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <20260209113229.7871-1-gustavopiazdasilva2102@gmail.com> <20260209113229.7871-2-gustavopiazdasilva2102@gmail.com> Content-Language: en-US From: Ovidiu Panait In-Reply-To: <20260209113229.7871-2-gustavopiazdasilva2102@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Gustavo, On 2/9/26 1:32 PM, Gustavo Piaz da Silva wrote: > Update has_rx_fifo and has_tx_fifo types from int to u32 in struct > axis_fifo. > > The of_property_read_u32() function expects a pointer to u32. Although > the current code works correctly with int, using u32 aligns the data > structure with the Device Tree API and prevents potential > type-mismatch issues. > > Signed-off-by: Gustavo Piaz da Silva > --- > drivers/staging/axis-fifo/axis-fifo.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c > index 509d620d6ce7..7bc7bf191250 100644 > --- a/drivers/staging/axis-fifo/axis-fifo.c > +++ b/drivers/staging/axis-fifo/axis-fifo.c > @@ -121,8 +121,8 @@ struct axis_fifo { > > unsigned int rx_fifo_depth; /* max words in the receive fifo */ > unsigned int tx_fifo_depth; /* max words in the transmit fifo */ > - int has_rx_fifo; /* whether the IP has the rx fifo enabled */ > - int has_tx_fifo; /* whether the IP has the tx fifo enabled */ > + u32 has_rx_fifo; /* whether the IP has the rx fifo enabled */ > + u32 has_tx_fifo; /* whether the IP has the tx fifo enabled */ > I think you are working with an older tree, these comments were removed in commit: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/commit/?h=staging-next&id=02b2a366a64f22cc367911d479297772d6269200 Could you please rebase the patches on top of the staging-next branch? https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/log/?h=staging-next Thanks, Ovidiu > wait_queue_head_t read_queue; /* wait queue for asynchronos read */ > struct mutex read_lock; /* lock for reading */