From: Markus Elfring <Markus.Elfring@web.de>
To: Abdun Nihaal <abdun.nihaal@gmail.com>, netdev@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Potnuri Bharat Teja <bharat@chelsio.com>,
Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,
Vishal Kulkarni <vishal@chelsio.com>
Subject: Re: [PATCH net-next] cxgb4: fix memory leak in cxgb4_init_ethtool_filters() error path
Date: Wed, 9 Apr 2025 17:47:46 +0200 [thread overview]
Message-ID: <5cb34dde-fb40-4654-806f-50e0c2ee3579@web.de> (raw)
In-Reply-To: <20250409054323.48557-1-abdun.nihaal@gmail.com>
…
> +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c
> @@ -2270,6 +2270,7 @@ int cxgb4_init_ethtool_filters(struct adapter *adap)
> eth_filter->port[i].bmap = bitmap_zalloc(nentries, GFP_KERNEL);
> if (!eth_filter->port[i].bmap) {
> ret = -ENOMEM;
> + kvfree(eth_filter->port[i].loc_array);
> goto free_eth_finfo;
> }
> }
How do you think about to move the shown error code assignment behind the mentioned label
(so that another bit of duplicate source code could be avoided)?
Regards,
Markus
next prev parent reply other threads:[~2025-04-09 15:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-09 5:43 [PATCH net-next] cxgb4: fix memory leak in cxgb4_init_ethtool_filters() error path Abdun Nihaal
2025-04-09 15:47 ` Markus Elfring [this message]
2025-04-11 14:57 ` Simon Horman
2025-04-11 16:22 ` Abdun Nihaal
2025-04-11 18:50 ` [PATCH] " Markus Elfring
2025-04-14 14:56 ` [PATCH net-next] " Simon Horman
2025-04-14 14:59 ` Simon Horman
2025-04-14 16:53 ` Abdun Nihaal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5cb34dde-fb40-4654-806f-50e0c2ee3579@web.de \
--to=markus.elfring@web.de \
--cc=abdun.nihaal@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=bharat@chelsio.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rahul.lakkireddy@chelsio.com \
--cc=vishal@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox