Re: [PATCH v3 01/11] media: videobuf2: Access vb2_queue bufs array through helper functions

kernel test robot
2023-06-23T15:13:20Z

Hi Benjamin,

kernel test robot noticed the following build errors:

[auto build test ERROR on media-tree/master]
[also build test ERROR on linus/master v6.4-rc7 next-20230623]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Benjamin-Gaignard/media-videobuf2-Access-vb2_queue-bufs-array-through-helper-functions/20230622-214122
base: git://linuxtv.org/media_tree.git master
patch link: https://lore.kernel.org/r/20230622131349.144160-2-benjamin.gaignard%40collabora.com
patch subject: [PATCH v3 01/11] media: videobuf2: Access vb2_queue bufs array through helper functions
config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20230623/202306232218.dOcWboPB-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230623/202306232218.dOcWboPB-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306232218.dOcWboPB-lkp@intel.com/

All errors (new ones prefixed by >>):

drivers/staging/media/atomisp/pci/atomisp_ioctl.c: In function 'atomisp_dqbuf_wrapper':
>> drivers/staging/media/atomisp/pci/atomisp_ioctl.c:1080:33: error: incompatible type for argument 1 of 'vb2_get_buffer'
1080 | vb = vb2_get_buffer(pipe->vb_queue, buf->index);
| ~~~~^~~~~~~~~~
| |
| struct vb2_queue
In file included from include/media/videobuf2-v4l2.h:16,
from drivers/staging/media/atomisp//pci/ia_css_frame_public.h:23,
from drivers/staging/media/atomisp/pci/sh_css_legacy.h:22,
from drivers/staging/media/atomisp/pci/atomisp_internal.h:34,
from drivers/staging/media/atomisp/pci/atomisp_cmd.h:30,
from drivers/staging/media/atomisp/pci/atomisp_ioctl.c:27:
include/media/videobuf2-core.h:1239:67: note: expected 'struct vb2_queue *' but argument is of type 'struct vb2_queue'
1239 | static inline struct vb2_buffer *vb2_get_buffer(struct vb2_queue *q,
| ~~~~~~~~~~~~~~~~~~^

vim +/vb2_get_buffer +1080 drivers/staging/media/atomisp/pci/atomisp_ioctl.c

1065
1066 static int atomisp_dqbuf_wrapper(struct file *file, void *fh, struct v4l2_buffer *buf)
1067 {
1068 struct video_device *vdev = video_devdata(file);
1069 struct atomisp_video_pipe *pipe = atomisp_to_video_pipe(vdev);
1070 struct atomisp_sub_device *asd = pipe->asd;
1071 struct atomisp_device *isp = video_get_drvdata(vdev);
1072 struct ia_css_frame *frame;
1073 struct vb2_buffer *vb;
1074 int ret;
1075
1076 ret = vb2_ioctl_dqbuf(file, fh, buf);
1077 if (ret)
1078 return ret;
1079
> 1080 vb = vb2_get_buffer(pipe->vb_queue, buf->index);
1081 frame = vb_to_frame(vb);
1082
1083 buf->reserved = asd->frame_status[buf->index];
1084
1085 /*
1086 * Hack:
1087 * Currently frame_status in the enum type which takes no more lower
1088 * 8 bit.
1089 * use bit[31:16] for exp_id as it is only in the range of 1~255
1090 */
1091 buf->reserved &= 0x0000ffff;
1092 if (!(buf->flags & V4L2_BUF_FLAG_ERROR))
1093 buf->reserved |= frame->exp_id;
1094 buf->reserved2 = pipe->frame_config_id[buf->index];
1095
1096 dev_dbg(isp->dev,
1097 "dqbuf buffer %d (%s) with exp_id %d, isp_config_id %d\n",
1098 buf->index, vdev->name, buf->reserved >> 16, buf->reserved2);
1099 return 0;
1100 }
1101

--
0-DAY CI Kernel Test Service