From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: Takashi Iwai <tiwai@suse.de>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Alsa-devel <alsa-devel@alsa-project.org>,
sound-open-firmware@alsa-project.org,
linux-kernel@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Cezary Rojewski <cezary.rojewski@intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
Matthew Auld <matthew.auld@intel.com>
Subject: Re: [PATCH] ASoC: SOF: Intel: Remove deferred probe for SOF
Date: Wed, 19 Jul 2023 17:59:52 +0200 [thread overview]
Message-ID: <5cd0d41b-8307-9db3-fb4f-037b181a390d@linux.intel.com> (raw)
In-Reply-To: <04ed7ed8-8a8d-427a-84e1-a326feee5547@sirena.org.uk>
Hey,
On 2023-07-19 14:39, Mark Brown wrote:
> On Wed, Jul 19, 2023 at 02:13:59PM +0200, Maarten Lankhorst wrote:
>>
>> On 2023-07-19 13:06, Takashi Iwai wrote:
>>> On Wed, 19 Jul 2023 11:48:06 +0200,
>>> Maarten Lankhorst wrote:
>>>>
>>>> The 60 seconds timeout is a thing "better than complete disablement",
>>>> so it's not ideal, either. Maybe we can add something like the
>>>> following:
>>>> - Check when the deferred probe takes too long, and warn it
>>>> - Provide some runtime option to disable the component binding, so
>>>> that user can work around it if needed
>>>> A module option to snd_hdac_i915_init would probably be the least of all evils
>>>> here.
>>>
>>> Yes, probably it's the easiest option and sufficient.
>>>
>>>
>>> thanks,
>>>
>>> Takashi
>> Hey,
>>
>> Patch below, can be applied immediately iresspective of the other patches.
>>
>> ---->8----------
>>
>> Selecting CONFIG_DRM selects CONFIG_VIDEO_NOMODESET, which exports
>> video_firmware_drivers_only(). This can be used as a first approximation
>> on whether i915 will be available. It's safe to use as this is only built
>
> Please don't bury new patches in the middle of mails, it just makes it
> hard to apply the patch since tooling doesn't understand what's going
> on.
>
> Please don't send new patches in reply to old patches or serieses, this
> makes it harder for both people and tools to understand what is going
> on - it can bury things in mailboxes and make it difficult to keep track
> of what current patches are, both for the new patches and the old ones.
I will send a new version in a bit, with all comments addressed.
I need to finish testing first.
~Maarten
next prev parent reply other threads:[~2023-07-19 16:00 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 8:45 [PATCH 0/7] sound: Use -EPROBE_DEFER instead of i915 module loading Maarten Lankhorst
2023-07-18 8:45 ` [PATCH 1/7] ALSA: hda/i915: Add an allow_modprobe argument to snd_hdac_i915_init Maarten Lankhorst
2023-07-18 8:45 ` [PATCH 2/7] ALSA: hda/i915: Allow xe as match for i915_component_master_match Maarten Lankhorst
2023-07-18 8:45 ` [PATCH 3/7] ASoC: Intel: avs: Move snd_hdac_i915_init to before probe_work Maarten Lankhorst
2023-07-18 14:11 ` Mark Brown
2023-07-19 15:26 ` Cezary Rojewski
2023-07-19 15:31 ` Takashi Iwai
2023-07-19 15:54 ` Maarten Lankhorst
2023-07-18 8:45 ` [PATCH 4/7] ASoC: Intel: Skylake: " Maarten Lankhorst
2023-07-18 14:12 ` Mark Brown
2023-07-18 8:45 ` [PATCH 5/7] ALSA: hda/intel: " Maarten Lankhorst
2023-07-18 9:57 ` Takashi Iwai
[not found] ` <2a727311-46d8-e999-1461-2ed2f1b704e0@linux.intel.com>
2023-07-18 12:17 ` [v2 PATCH 1/2] ALSA: hda/intel: Fix error handling in azx_probe() Takashi Iwai
2023-07-18 8:45 ` [PATCH 6/7] ASoC: SOF: Intel: Remove deferred probe for SOF Maarten Lankhorst
2023-07-18 14:13 ` Mark Brown
2023-07-18 17:04 ` Kai Vehmanen
2023-07-19 6:01 ` Takashi Iwai
[not found] ` <66d22637-069f-5262-2249-6041ef9d4614@linux.intel.com>
2023-07-19 11:06 ` Takashi Iwai
2023-07-19 12:13 ` [PATCH] " Maarten Lankhorst
2023-07-19 12:39 ` Mark Brown
2023-07-19 15:59 ` Maarten Lankhorst [this message]
2023-07-19 12:47 ` Takashi Iwai
2023-07-19 13:32 ` [PATCH 6/7] " Kai Vehmanen
2023-07-18 8:45 ` [PATCH 7/7] ALSA: hda/i915: Remove extra argument from snd_hdac_i915_init Maarten Lankhorst
2023-07-18 9:50 ` [PATCH 0/7] sound: Use -EPROBE_DEFER instead of i915 module loading Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5cd0d41b-8307-9db3-fb4f-037b181a390d@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=daniel.baluta@nxp.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.auld@intel.com \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sound-open-firmware@alsa-project.org \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox