From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753845AbdK1MTm (ORCPT ); Tue, 28 Nov 2017 07:19:42 -0500 Received: from mga03.intel.com ([134.134.136.65]:20784 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753714AbdK1MTk (ORCPT ); Tue, 28 Nov 2017 07:19:40 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,468,1505804400"; d="scan'208";a="1249445208" Subject: Re: [PATCH v2 04/10] perf util: Add rbtree node_delete ops To: Jiri Olsa Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com References: <1511791650-24072-1-git-send-email-yao.jin@linux.intel.com> <1511791650-24072-5-git-send-email-yao.jin@linux.intel.com> <20171128111228.GC2732@krava> From: "Jin, Yao" Message-ID: <5ce197f9-4a5b-cbc7-e407-716396aea8b8@linux.intel.com> Date: Tue, 28 Nov 2017 20:19:33 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171128111228.GC2732@krava> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/28/2017 7:12 PM, Jiri Olsa wrote: > On Mon, Nov 27, 2017 at 10:07:24PM +0800, Jin Yao wrote: >> In current stat-shadow.c, the rbtree deleting is ignored. >> >> The patch reconstructs the code of rblist init/free, and adds >> the implementation to node_delete method of rblist. >> >> Signed-off-by: Jin Yao >> --- >> tools/perf/util/stat-shadow.c | 33 +++++++++++++++++++++++++++++---- >> tools/perf/util/stat.h | 3 +++ >> 2 files changed, 32 insertions(+), 4 deletions(-) >> >> diff --git a/tools/perf/util/stat-shadow.c b/tools/perf/util/stat-shadow.c >> index c53b80d..0fdd2aa 100644 >> --- a/tools/perf/util/stat-shadow.c >> +++ b/tools/perf/util/stat-shadow.c >> @@ -40,6 +40,7 @@ static struct stats runtime_aperf_stats[NUM_CTX][MAX_NR_CPUS]; >> static struct rblist runtime_saved_values; >> static bool have_frontend_stalled; >> >> +struct runtime_stat rt_stat; >> struct stats walltime_nsecs_stats; >> >> struct saved_value { >> @@ -103,6 +104,18 @@ static struct rb_node *saved_value_new(struct rblist *rblist __maybe_unused, >> return &nd->rb_node; >> } >> >> +static void saved_value_delete(struct rblist *rblist __maybe_unused, >> + struct rb_node *rb_node) >> +{ >> + struct saved_value *v; >> + >> + BUG_ON(!rb_node); >> + v = container_of(rb_node, >> + struct saved_value, >> + rb_node); > > any reason for this to be cut on 3 lines? single line wouldn't cross 80 chars length.. > > jirka > Oh, yes, one line is enough. I will fix that. Thanks Jin Yao