From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0CAD36B06F for ; Mon, 13 Apr 2026 09:40:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776073236; cv=none; b=Y8DaWJq0nhRE8qF3xq1Zs5McWYSmlxpQk60ndjgkIKuSppOyVfqEtfiaPtXdmTXrGSVy/qvDKW5NjXP/mJV9RMfqaWsN+PaCHdCj9QcVhOxfh6XGdwUdCmmKfIB7GOqllPtua40l8OW8HwGpK69vgFvO8r4FsEWnRQ4nZg5H03I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776073236; c=relaxed/simple; bh=8H6eo3yw58JLVrYE2pETANA18w4CJWqHWda3KTnA8Fg=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=MCWv6hkjKJjunUxBHIFzh4eH0nyHM+b0KvEfSA0TKYyeboJs0AmCeVcbbmXrFrs4clLc/plhq6sORQ/+6raIWIhsdEUHtoN1oHfcMwqP7q8jxvtMKQTJAIxVNgIAmfte2MySK+2NczLRtyi1FHVVCZj94v2FmLLrut1ZOTOxKPE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mtXljpZs; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mtXljpZs" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8068EC116C6; Mon, 13 Apr 2026 09:40:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776073235; bh=8H6eo3yw58JLVrYE2pETANA18w4CJWqHWda3KTnA8Fg=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=mtXljpZsh449AXWeuGCcWtkaLHjQzyF42ikkSOIX3YLVdI4VrdCVQWwuhEks2St9I YlEaD87TaKw1QKlf2i89waOr/jWOEwjDq9EnUwKRZJmz4uGRmIJuuftNk7o4/5nCxN A/0MjhFKZsoir0sVyTD2foLgpk/qVygyvBxeGMNcLW99r8gldJFjhFN5JQfBBFiQuy 6gw4+nY/RfAFtYzTElO+orn9Fr5TZpIsCpQunMK+noHgwbH1k8TaOAKG3ptbhAT2ib fEm9a6ewjR3LNYIXr+koReL+xJqSJQcmZD1ko9p/GZWKukRTmJeK7t6DwMRTwwtmsH MIBMoeB7LwN/A== Message-ID: <5cf2e3ba-c222-4ffb-8238-45d641f6f7c7@kernel.org> Date: Mon, 13 Apr 2026 17:40:33 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: chao@kernel.org Subject: Re: [f2fs-dev] [PATCH] f2fs: allow empty mount string for Opt_usr|grp|projjquota To: Jaegeuk Kim , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net References: <20260331174326.231867-1-jaegeuk@kernel.org> Content-Language: en-US From: Chao Yu In-Reply-To: <20260331174326.231867-1-jaegeuk@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/1/2026 1:43 AM, Jaegeuk Kim via Linux-f2fs-devel wrote: > The fsparam_string_empty() gives an error when mounting without string, since > its type is set to fsparam_flag in VFS. So, let's allow the flag as well. > > This addresses xfstests/f2fs/015 and f2fs/021. > Fixes: d18535132523 ("f2fs: separate the options parsing and options checking") ? Reviewed-by: Chao Yu Thanks, > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/super.c | 27 +++++++++++++++------------ > 1 file changed, 15 insertions(+), 12 deletions(-) > > diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c > index 5330ef981340..aab4345f3ee7 100644 > --- a/fs/f2fs/super.c > +++ b/fs/f2fs/super.c > @@ -337,9 +337,12 @@ static const struct fs_parameter_spec f2fs_param_specs[] = { > fsparam_flag("usrquota", Opt_usrquota), > fsparam_flag("grpquota", Opt_grpquota), > fsparam_flag("prjquota", Opt_prjquota), > - fsparam_string_empty("usrjquota", Opt_usrjquota), > - fsparam_string_empty("grpjquota", Opt_grpjquota), > - fsparam_string_empty("prjjquota", Opt_prjjquota), > + fsparam_string("usrjquota", Opt_usrjquota), > + fsparam_flag("usrjquota", Opt_usrjquota), > + fsparam_string("grpjquota", Opt_grpjquota), > + fsparam_flag("grpjquota", Opt_grpjquota), > + fsparam_string("prjjquota", Opt_prjjquota), > + fsparam_flag("prjjquota", Opt_prjjquota), > fsparam_flag("nat_bits", Opt_nat_bits), > fsparam_enum("jqfmt", Opt_jqfmt, f2fs_param_jqfmt), > fsparam_enum("alloc_mode", Opt_alloc, f2fs_param_alloc_mode), > @@ -980,26 +983,26 @@ static int f2fs_parse_param(struct fs_context *fc, struct fs_parameter *param) > ctx_set_opt(ctx, F2FS_MOUNT_PRJQUOTA); > break; > case Opt_usrjquota: > - if (!*param->string) > - ret = f2fs_unnote_qf_name(fc, USRQUOTA); > - else > + if (param->type == fs_value_is_string && *param->string) > ret = f2fs_note_qf_name(fc, USRQUOTA, param); > + else > + ret = f2fs_unnote_qf_name(fc, USRQUOTA); > if (ret) > return ret; > break; > case Opt_grpjquota: > - if (!*param->string) > - ret = f2fs_unnote_qf_name(fc, GRPQUOTA); > - else > + if (param->type == fs_value_is_string && *param->string) > ret = f2fs_note_qf_name(fc, GRPQUOTA, param); > + else > + ret = f2fs_unnote_qf_name(fc, GRPQUOTA); > if (ret) > return ret; > break; > case Opt_prjjquota: > - if (!*param->string) > - ret = f2fs_unnote_qf_name(fc, PRJQUOTA); > - else > + if (param->type == fs_value_is_string && *param->string) > ret = f2fs_note_qf_name(fc, PRJQUOTA, param); > + else > + ret = f2fs_unnote_qf_name(fc, PRJQUOTA); > if (ret) > return ret; > break;