From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <poza@codeaurora.org>
X-Google-Smtp-Source: ACJfBotP8Eiv7bcOg1StI6m0CISKHZcMkY9BBdAOV271tz0Oj9bGI8Ac6U0BMSnL6Oqg/ViCSmDC
ARC-Seal: i=1; a=rsa-sha256; t=1516255030; cv=none;
        d=google.com; s=arc-20160816;
        b=M60BhOaVaQWD02hZu2krIuHR2JC9T0h/nRaO6jdUjCEU5WNYx1nLj7FM4C8ymxkehn
         KN7ykorTw+Uc/jniGQGInBudvvjHpKN55LXMeibbxVSM+jXXnJPxVSZhbg0BuXFD+0D1
         9ID0kikZcl/+tTXvfHd/1fcreZuMST9obfT6TGG4EzYQ7tbUVjGzwNjcXOvY2uOPocXL
         6J9RqEETZSpbumKeur81ct+fBqFanCYTedBgLO8H+2dxfiIJr+Y14fztBBmFtMHiBizr
         a/WHJhsPW8prtIpZ4ORjHtygyuWos1sqlGx1LPbrrTPQhffw2Qx6zlXBsQDGrpFOOzHn
         qhxA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=user-agent:message-id:references:in-reply-to:subject:cc:to:from
         :date:content-transfer-encoding:mime-version:dkim-signature
         :dkim-signature:arc-authentication-results;
        bh=eU0kB3Hw7i1AfzBQhLHOn6aQS+thVbPH9EUqm81r3fg=;
        b=mRDq8TQ8BvqCc0iId7BIXnbS2dqMTP14qNrIzchK3h7O2P5xq9ci2ZAYLQjRpOQF4U
         ShlyuxmKzvWBD/wtn5TyzPjsQWa0HT2OgtTPELfRvinZoe2v+andBeKq2zXV0tfTWj4C
         /yXQvqxjGDTgo+Rd0XUjfCVBokQhhRXs3vJQQVm6HPF9UC6/KnoZhRM+ymScileDGWZg
         paN09qwFTHLQpa7Whvd5PdmkyPlwsMM+zm/0b8znvVmRl/zyfOWIqyJXgm9zBZCxjNxF
         CbE2oSJe8n3/hRVUvx2MJl2hZCUBoj0yfQdGfvghxBRAijA8bUpGDT8n68d2PwNJYqL2
         PegQ==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@codeaurora.org header.s=default header.b=iSWoakrw;
       dkim=pass header.i=@codeaurora.org header.s=default header.b=iSWoakrw;
       spf=pass (google.com: domain of poza@codeaurora.org designates 198.145.29.96 as permitted sender) smtp.mailfrom=poza@codeaurora.org
Authentication-Results: mx.google.com;
       dkim=pass header.i=@codeaurora.org header.s=default header.b=iSWoakrw;
       dkim=pass header.i=@codeaurora.org header.s=default header.b=iSWoakrw;
       spf=pass (google.com: domain of poza@codeaurora.org designates 198.145.29.96 as permitted sender) smtp.mailfrom=poza@codeaurora.org
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date: Thu, 18 Jan 2018 11:27:09 +0530
From: poza@codeaurora.org
To: Sinan Kaya <okaya@codeaurora.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>, Philippe Ombredanne
 <pombredanne@nexb.com>, Thomas Gleixner <tglx@linutronix.de>, Greg
 Kroah-Hartman <gregkh@linuxfoundation.org>, Kate Stewart
 <kstewart@linuxfoundation.org>, linux-pci@vger.kernel.org,
 linux-kernel@vger.kernel.org, Dongdong Liu <liudongdong3@huawei.com>, Keith
 Busch <keith.busch@intel.com>, Wei Zhang <wzhang@fb.com>, Timur Tabi
 <timur@codeaurora.org>
Subject: Re: [PATCH v5 3/4] PCI/DPC: Unify and plumb error handling into DPC
In-Reply-To: <c77a3302e34d55d557404d7bdc6892fc@codeaurora.org>
References: <1516185438-31556-1-git-send-email-poza@codeaurora.org>
 <1516185438-31556-4-git-send-email-poza@codeaurora.org>
 <733abfcb-5b31-7394-ab62-19a0888d71c2@codeaurora.org>
 <c77a3302e34d55d557404d7bdc6892fc@codeaurora.org>
Message-ID: <5cf7004e62a2979afb3c29e99d705c60@codeaurora.org>
User-Agent: Roundcube Webmail/1.2.5
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: =?utf-8?q?1589835690475100377?=
X-GMAIL-MSGID: =?utf-8?q?1589908634320526047?=
X-Mailing-List: linux-kernel@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>

On 2018-01-18 10:47, poza@codeaurora.org wrote:
> On 2018-01-17 22:16, Sinan Kaya wrote:
>> On 1/17/2018 5:37 AM, Oza Pawandeep wrote:
>>> +++ b/include/linux/dpc.h
>>> @@ -0,0 +1,9 @@
>>> +/* SPDX-License-Identifier: GPL-2.0 */
>>> +
>>> +#ifndef _DPC_H_
>>> +#define _DPC_H_
>>> +
>>> +#define DPC_FATAL		4
>>> +
>>> +#endif //_DPC_H_
>>> +
>> 
>> can you keep this in drivers/pci.h and get rid of this file?
> 
> I thought about this, but if I keep it in drivers/pci.h,
> then AER's defines have to be in that as well. (for unification)
> 
> and then all the dependent files who are using AER_FATAL such as
> drivers/acpi/apei/ghees.c
> have to go on including this drivers file which is odd way of doing it.
> 
> So I am not very sure about this....since AER_FATAL are in aer.h, I
> have made dpc.h
> 
> 
> Regards,
> Oza.

Should I be doing in next patch-set series ?