From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B94AC0650F for ; Mon, 5 Aug 2019 21:02:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2C86C20C01 for ; Mon, 5 Aug 2019 21:02:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="fWEhDH71" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730650AbfHEVCv (ORCPT ); Mon, 5 Aug 2019 17:02:51 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:37602 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730099AbfHEVCv (ORCPT ); Mon, 5 Aug 2019 17:02:51 -0400 Received: by mail-pg1-f195.google.com with SMTP id d1so7530061pgp.4 for ; Mon, 05 Aug 2019 14:02:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=message-id:mime-version:content-transfer-encoding:in-reply-to :references:subject:from:cc:to:user-agent:date; bh=uMVmeu4mdexdqU41liFV6boDUEQu0SlMK35Wx76U6rQ=; b=fWEhDH71W06T3024ETGhhgrpXzwlOn9eSdQr0TzByAtVcHPr5TVTvBfe3MLFjn8JNr fptB9Za0YySQe54L+mGjMUAaYQUicXz48Ta4el70D9SHQhbLW8zXoQj5+Cnrqv/XVgVh biPY1LDvezl01zVWbBeV8IZ3lhX34QANjm7Ao= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:mime-version :content-transfer-encoding:in-reply-to:references:subject:from:cc:to :user-agent:date; bh=uMVmeu4mdexdqU41liFV6boDUEQu0SlMK35Wx76U6rQ=; b=PcPjXA7MEPgEDgr+4Vr34c0BHEooE27sXkV4gUm6abGUgTT67LIYvSn9YEw00zmac9 DeFPlZMCGPMNWQ5O93KT6IL2H53T0DrVzVqhV0jy0EbY48p4UVq7UyaXbka4G6CEgkAS UfE+rGyB9TSJqI16o4/C/83jDelLfYOzaEh/WIPtn+7LF2VmFrSMU+2dJXBXc8enBbbC JE+Zg1X31nCXR/AqHWWCcY1a5jfH/BsmU8dMKfA8qIzZNjsOgqocFZyWg3f1Ftixz1qO z6RGZ7pdRvt2E8NFrFY5UfWyUPyQMFRwOPiF7XuTwNyOYMDeFUEXX/6l/edGBsFJxdIZ q4bw== X-Gm-Message-State: APjAAAW4A5uxX6iAfXz2Hfg4tfK192brfFi76ipjotCJmUqOZ16R6PQB NOyFJ4LMrYbXJgeL8zqNJ2pMNw== X-Google-Smtp-Source: APXvYqzPqg8YsUI6ORm0RYGZBvQh+47+wA0FAnK1obUP/lbkhgT9hEqgCPBEcxjSX/A3ucR/P+9qKA== X-Received: by 2002:a17:90a:2247:: with SMTP id c65mr19374065pje.24.1565038970368; Mon, 05 Aug 2019 14:02:50 -0700 (PDT) Received: from chromium.org ([2620:15c:202:1:fa53:7765:582b:82b9]) by smtp.gmail.com with ESMTPSA id x9sm59934438pgp.75.2019.08.05.14.02.49 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 05 Aug 2019 14:02:49 -0700 (PDT) Message-ID: <5d489979.1c69fb81.9480d.fd19@mx.google.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20190805175848.163558-4-trong@android.com> References: <20190805175848.163558-1-trong@android.com> <20190805175848.163558-4-trong@android.com> Subject: Re: [PATCH v7 3/3] PM / wakeup: Show wakeup sources stats in sysfs From: Stephen Boyd Cc: rafael@kernel.org, hridya@google.com, sspatil@google.com, kaleshsingh@google.com, ravisadineni@chromium.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, kernel-team@android.com, Tri Vo To: Tri Vo , gregkh@linuxfoundation.org, rjw@rjwysocki.net, viresh.kumar@linaro.org User-Agent: alot/0.8.1 Date: Mon, 05 Aug 2019 14:02:48 -0700 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Tri Vo (2019-08-05 10:58:48) > diff --git a/drivers/base/power/wakeup_stats.c b/drivers/base/power/wakeu= p_stats.c > new file mode 100644 > index 000000000000..3a4f55028e27 > --- /dev/null > +++ b/drivers/base/power/wakeup_stats.c > @@ -0,0 +1,161 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Wakeup statistics in sysfs > + * > + * Copyright (c) 2019 Linux Foundation > + * Copyright (c) 2019 Greg Kroah-Hartman > + * Copyright (c) 2019 Google Inc. > + */ > + > +#include > +#include > +#include > +#include Can you include init.h, device.h, timekeeping.h, and kernel. here? This file calls functions exported in those headers. > + > +#include "power.h" > + > +static struct class *wakeup_class; > + > +#define wakeup_attr(_name) \ > +static ssize_t _name##_show(struct device *dev, = \ > + struct device_attribute *attr, char *buf) \ > +{ \ > + struct wakeup_source *ws =3D dev_get_drvdata(dev); = \ > + \ > + return sprintf(buf, "%lu\n", ws->_name); \ > +} \ > +static DEVICE_ATTR_RO(_name) > + > +wakeup_attr(active_count); > +wakeup_attr(event_count); > +wakeup_attr(wakeup_count);